refactor(lading): annotate intentional-panic blackhole + small generator sites#1897
Draft
goxberry wants to merge 1 commit into
Draft
Conversation
…tor sites Attach fn-level #[expect(clippy::expect_used, reason = "...")] to construction- and startup-time sites in the lading crate whose `.expect()` calls intentionally panic on system-resource exhaustion or other documented contracts. Convert the Cat-3 Response::builder().body() and HeaderValue::parse sites inside otlp/http.rs to unreachable!() to match the rest of the codebase. - blackhole/otlp/http.rs::new (serde_json on default OTLP responses) - blackhole/tcp_rr.rs::run (set_nonblocking on bound listener) - blackhole/tcp_rr.rs::create_listener (socket-setup syscalls) - blackhole/tcp_rr.rs::server_thread_main (mio Poll/registry setup) - generator/container.rs::spin (u32::try_from on bounded idx) - generator/file_tree.rs::spin (iter().cycle() over non-empty Vec) Co-Authored-By: Claude Opus 4.7 <[email protected]>
This was referenced May 23, 2026
Contributor
Author
This was referenced May 23, 2026
|
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Annotate intentional-panic
.expect()sites in the blackhole subsystem and a few small generator constructors with fn-level#[expect(clippy::expect_used, reason = "...")]. Convert the Cat-3-eligibleResponse::builder().body()andHeaderValue::from_staticsites insideotlp/http.rstounreachable!(), matching the rest of the codebase.Sites annotated:
Stacked on #1896. Part of the broader push toward enforcing
clippy::expect_used = "deny"workspace-wide.Test plan