Skip to content

docs(build): align AGENTS.md with JDK 21 requirement [PROF-16537] - #967

Open
kaahos wants to merge 2 commits into
mainfrom
paul.fournillon/docs-build-jdk-requirement
Open

kaahos wants to merge 2 commits into
mainfrom
paul.fournillon/docs-build-jdk-requirement

Conversation

@kaahos

@kaahos kaahos commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?:
Correct the build-JDK requirement in AGENTS.md from JDK 17+ to JDK 21+. Preserve the distinction between the build JDK and JAVA_TEST_HOME.

Motivation:
PROF-16537: agent guidance contradicts the JDK 21+ project prerequisite in README.md. Gradle's own minimum JVM version is not the project's chosen build requirement.

Additional Notes:

  • Documentation only: one changed line in AGENTS.md. No build configuration, CI, formatter, bytecode target or runtime behavior changes.
  • Independent committed-range code-review completed with no findings or waivers. This is not merge approval.

How to test the change?:

  • passed: scoped :spotlessApply :spotlessCheck -PspotlessIdeHook=AGENTS.md --max-workers=2 --no-build-cache through ./.claude/commands/build-and-summarize on JDK 25.0.4.1. This is not a full-repository formatting result.
  • passed: copyright, canonical CLAUDE.md, knowledgebase and documentation-index checks; git diff --check; exact one-line scope assertion.
  • passed: requirement checked against README.md, doc/building/JdkUpgrades.md and the existing JDK 21 CI configuration.
  • not applicable: profiler/native runtime tests; no executable behavior changes.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a security review (run the dd:platform-security-review
    skill, or file a request via the PSEC review form).
    bewaire also runs automatically on every PR.
  • This PR doesn't touch any of that.
  • JIRA: PROF-16537

Unsure? Have a question? Request a review!

@kaahos
kaahos marked this pull request as ready for review November 10, 2026 11:10
@kaahos
kaahos requested a review from a team as a code owner November 10, 2026 11:10
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T11:10:58.353537Z bb77356 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The JDK 21+ build guidance matches the documented project prerequisite and existing CI configuration while preserving the separate JAVA_TEST_HOME setting.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit bb77356

@dd-octo-sts

dd-octo-sts Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Scan-Build Report

User:runner@runnervmwuk1x
Working Directory:/home/runner/work/java-profiler/java-profiler/ddprof-lib/src/test/make
Command Line:make -j4 all
Clang Version:Ubuntu clang version 21.1.8 (6ubuntu1)
Date:Tue Nov 10 19:20:49 2026

Bug Summary

Bug TypeQuantityDisplay?
All Bugs2
Logic error
Dereference of null pointer1
Unused code
Dead initialization1

Filter Results by File

Reports

Bug Group Bug Type ▾ File Function/Method Line Path Length
Unused codeDead initializationreferenceChains.cppapplyOomRamp4971
Logic errorDereference of null pointerperfEvents_linux.cppunregisterThread72026

@dd-octo-sts

dd-octo-sts Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

CI Test Results

Run: #42884078847 | Commit: 25a2492 | Duration: 20m 4s (longest job)

✅ All 32 test jobs passed

Status Overview

JDK glibc-aarch64/debug glibc-amd64/debug musl-aarch64/debug musl-amd64/debug
8 - ✅ - -
8-ibm - ✅ - -
8-j9 ✅ ✅ - -
8-librca - - ✅ ✅
8-orcl - ✅ - -
11 - ✅ - -
11-j9 ✅ ✅ - -
11-librca - - ✅ ✅
17 ✅ ✅ - -
17-graal ✅ ✅ - -
17-j9 ✅ ✅ - -
17-librca - - ✅ ✅
21 ✅ ✅ - -
21-graal ✅ ✅ - -
21-librca - - ✅ ✅
25 ✅ ✅ - -
25-graal ✅ ✅ - -
25-librca - - ✅ ✅

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Summary: Total: 32 | Passed: 32 | Failed: 0


Updated: 2026-11-10 19:41:40 UTC

@dd-octo-sts

dd-octo-sts Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

✅ All 40 integration tests passed

📊 Dashboard · 👷 Pipeline · 📦 6f449f78

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant