Repository navigation
Conversation
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 3 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 49fbcb5 | Docs | View more details | Give us feedback! |
Reliability & Chaos Results❌ 1 failure(s) detected Pipeline: https://gitlab.ddbuild.io/DataDog/java-profiler/-/pipelines/152103616 ❌ chaos: profiler tcmalloc amd64 21 0 3 temXchaos |
Scan-Build Report
Bug Summary
Filter Results by FileReports
|
|||||||||||||||||||||||||||||||||||||||||||||||||
CI Test ResultsRun: #42924406212 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled ❌ Failing tests
Retried 1 of 102 cells. Failed Jobs
Summary: Total: 108 | Passed: 107 | Failed: 1 Updated: 2026-11-11 00:03:16 UTC |
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
More details
The completed static review found no actionable defect in the interrupted-frame checks, receiver capture, or recovery-budget handling. Runtime behavior was not independently exercised.
🤖 Bits Code Review · Commit 89838e9
f2a50c1 to
49fbcb5
Compare
There was a problem hiding this comment.
More details
Receiver capture guards against stale interrupted registers and reserves capacity for recovery or an error frame. Runtime integration and sanitizer behavior were not revalidated.
🤖 Bits Code Review · Commit 49fbcb5
What does this PR do?:
Captures vtable receivers during ASGCT stub recovery without changing platform defaults. Shares capture with the VM walker and verifies the synthetic frame’s receiver class.
Motivation:
macOS defaults to DWARF/ASGCT, which emitted vtable stubs without receiver metadata.
Additional Notes:
Independent agent review found no verified defects. Compact-header decoding is unchanged. Verification gaps below remain open.
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a security review (run the
dd:platform-security-reviewskill, or file a request via the PSEC review form).
bewairealso runs automatically on every PR.