[CONTP-1612] support enabling untaint controller in datadog chart - #2782
Open
adel121 wants to merge 4 commits into
Open
[CONTP-1612] support enabling untaint controller in datadog chart#2782adel121 wants to merge 4 commits into
adel121 wants to merge 4 commits into
Conversation
adel121
changed the base branch from
main
to
CONTP-1612/untaint-controller-config
July 9, 2026 12:34
7 tasks
adel121
marked this pull request as ready for review
July 9, 2026 12:53
This comment has been minimized.
This comment has been minimized.
…oller-in-datadog-chart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET
What this PR does / why we need it:
Which issue this PR fixes
For Helm-managed clusters (agent installed via charts/datadog, no operator managing the agent), users need to opt the agent into tolerating the startup taint so it can schedule on tainted nodes. The untaint controller's pod label selector already works for Helm-managed agents — charts/datadog uses agent.datadoghq.com/component: agent on the node agent DaemonSet — so no label change is needed, only the toleration.
In this PR, we:
operator.untaintController.enabledvalue (default false) to values.yamlDaemonSettemplate when enabled, and activate the untaint controller feature in the operator.DaemonSetTesting
Added unit test
Manual testing:
Deploy the agent using helm chart with the added option enabled. Ensure the toleration is added properly:
Deployed agent with appended at the end of
values.yml:Checked that the toleration was properly added:
Special notes for your reviewer:
The CSI driver may also need a similar change, but since CSI is usually used as a subchart (dependency of the agent chart), and the user can already set tolerations manually on the CSI by editing
datadog_csi_driversection in datadog values.yaml, I am keeping it for a future PR to asses if it is worth adding a separate config option for CSI or not.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version,<chartName>/patch-version, or<chartName>/no-version-bump)datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)datadogchart changes, received ✅ from a member of your teamGitHub CI takes care of the below, but are still required:
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mdDO NOT MERGE YET