-
Notifications
You must be signed in to change notification settings - Fork 323
Service discovery: defer FFM methodhandles resolutions #10312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~520986d07b, baseline=1.59.0-SNAPSHOT~419da213f7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1089338
Total [baseline] (10.918 s) : 0, 10918037
Agent [candidate] (1.086 s) : 0, 1086209
Total [candidate] (10.726 s) : 0, 10725837
section appsec
Agent [baseline] (1.261 s) : 0, 1261490
Total [baseline] (10.926 s) : 0, 10926492
Agent [candidate] (1.264 s) : 0, 1263601
Total [candidate] (10.948 s) : 0, 10948130
section iast
Agent [baseline] (1.222 s) : 0, 1222183
Total [baseline] (11.225 s) : 0, 11225456
Agent [candidate] (1.236 s) : 0, 1235589
Total [candidate] (10.395 s) : 0, 10395234
section profiling
Agent [baseline] (1.213 s) : 0, 1212849
Total [baseline] (10.991 s) : 0, 10991342
Agent [candidate] (1.202 s) : 0, 1201765
Total [candidate] (10.904 s) : 0, 10903787
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~520986d07b, baseline=1.59.0-SNAPSHOT~419da213f7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (653.287 ms) : 0, 653287
BytebuddyAgent [candidate] (652.184 ms) : 0, 652184
GlobalTracer [baseline] (283.767 ms) : 0, 283767
GlobalTracer [candidate] (282.746 ms) : 0, 282746
AppSec [baseline] (32.979 ms) : 0, 32979
AppSec [candidate] (32.653 ms) : 0, 32653
Debugger [baseline] (68.842 ms) : 0, 68842
Debugger [candidate] (68.411 ms) : 0, 68411
Remote Config [baseline] (645.871 µs) : 0, 646
Remote Config [candidate] (619.6 µs) : 0, 620
Telemetry [baseline] (9.121 ms) : 0, 9121
Telemetry [candidate] (9.119 ms) : 0, 9119
Flare Poller [baseline] (3.825 ms) : 0, 3825
Flare Poller [candidate] (3.751 ms) : 0, 3751
section appsec
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (689.233 ms) : 0, 689233
BytebuddyAgent [candidate] (690.389 ms) : 0, 690389
GlobalTracer [baseline] (257.161 ms) : 0, 257161
GlobalTracer [candidate] (257.717 ms) : 0, 257717
IAST [baseline] (24.556 ms) : 0, 24556
IAST [candidate] (24.642 ms) : 0, 24642
AppSec [baseline] (172.14 ms) : 0, 172140
AppSec [candidate] (172.179 ms) : 0, 172179
Debugger [baseline] (67.935 ms) : 0, 67935
Debugger [candidate] (68.254 ms) : 0, 68254
Remote Config [baseline] (728.552 µs) : 0, 729
Remote Config [candidate] (794.941 µs) : 0, 795
Telemetry [baseline] (9.387 ms) : 0, 9387
Telemetry [candidate] (9.328 ms) : 0, 9328
Flare Poller [baseline] (3.775 ms) : 0, 3775
Flare Poller [candidate] (3.799 ms) : 0, 3799
section iast
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (790.285 ms) : 0, 790285
BytebuddyAgent [candidate] (799.523 ms) : 0, 799523
GlobalTracer [baseline] (256.091 ms) : 0, 256091
GlobalTracer [candidate] (258.62 ms) : 0, 258620
IAST [baseline] (26.999 ms) : 0, 26999
IAST [candidate] (27.269 ms) : 0, 27269
AppSec [baseline] (34.147 ms) : 0, 34147
AppSec [candidate] (35.573 ms) : 0, 35573
Debugger [baseline] (65.478 ms) : 0, 65478
Debugger [candidate] (65.154 ms) : 0, 65154
Remote Config [baseline] (588.115 µs) : 0, 588
Remote Config [candidate] (581.355 µs) : 0, 581
Telemetry [baseline] (8.578 ms) : 0, 8578
Telemetry [candidate] (8.58 ms) : 0, 8580
Flare Poller [baseline] (3.54 ms) : 0, 3540
Flare Poller [candidate] (3.58 ms) : 0, 3580
section profiling
crashtracking [baseline] (1.229 ms) : 0, 1229
crashtracking [candidate] (1.222 ms) : 0, 1222
BytebuddyAgent [baseline] (708.001 ms) : 0, 708001
BytebuddyAgent [candidate] (701.16 ms) : 0, 701160
GlobalTracer [baseline] (221.522 ms) : 0, 221522
GlobalTracer [candidate] (219.66 ms) : 0, 219660
AppSec [baseline] (32.353 ms) : 0, 32353
AppSec [candidate] (32.002 ms) : 0, 32002
Debugger [baseline] (68.7 ms) : 0, 68700
Debugger [candidate] (68.011 ms) : 0, 68011
Remote Config [baseline] (646.479 µs) : 0, 646
Remote Config [candidate] (635.857 µs) : 0, 636
Telemetry [baseline] (8.852 ms) : 0, 8852
Telemetry [candidate] (8.725 ms) : 0, 8725
Flare Poller [baseline] (3.714 ms) : 0, 3714
Flare Poller [candidate] (3.669 ms) : 0, 3669
ProfilingAgent [baseline] (97.806 ms) : 0, 97806
ProfilingAgent [candidate] (97.118 ms) : 0, 97118
Profiling [baseline] (98.397 ms) : 0, 98397
Profiling [candidate] (97.693 ms) : 0, 97693
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~520986d07b, baseline=1.59.0-SNAPSHOT~419da213f7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087984
Total [baseline] (8.737 s) : 0, 8737248
Agent [candidate] (1.085 s) : 0, 1084870
Total [candidate] (8.755 s) : 0, 8755012
section iast
Agent [baseline] (1.219 s) : 0, 1218714
Total [baseline] (9.308 s) : 0, 9307653
Agent [candidate] (1.22 s) : 0, 1220244
Total [candidate] (9.344 s) : 0, 9343668
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~520986d07b, baseline=1.59.0-SNAPSHOT~419da213f7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (654.225 ms) : 0, 654225
BytebuddyAgent [candidate] (652.27 ms) : 0, 652270
GlobalTracer [baseline] (283.476 ms) : 0, 283476
GlobalTracer [candidate] (282.415 ms) : 0, 282415
AppSec [baseline] (32.865 ms) : 0, 32865
AppSec [candidate] (32.704 ms) : 0, 32704
Debugger [baseline] (67.327 ms) : 0, 67327
Debugger [candidate] (67.279 ms) : 0, 67279
Remote Config [baseline] (628.88 µs) : 0, 629
Remote Config [candidate] (619.222 µs) : 0, 619
Telemetry [baseline] (8.985 ms) : 0, 8985
Telemetry [candidate] (8.928 ms) : 0, 8928
Flare Poller [baseline] (3.71 ms) : 0, 3710
Flare Poller [candidate] (3.739 ms) : 0, 3739
section iast
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (788.166 ms) : 0, 788166
BytebuddyAgent [candidate] (788.933 ms) : 0, 788933
GlobalTracer [baseline] (255.362 ms) : 0, 255362
GlobalTracer [candidate] (255.037 ms) : 0, 255037
IAST [baseline] (26.869 ms) : 0, 26869
IAST [candidate] (26.905 ms) : 0, 26905
AppSec [baseline] (33.41 ms) : 0, 33410
AppSec [candidate] (32.664 ms) : 0, 32664
Debugger [baseline] (65.837 ms) : 0, 65837
Debugger [candidate] (67.456 ms) : 0, 67456
Remote Config [baseline] (590.753 µs) : 0, 591
Remote Config [candidate] (616.989 µs) : 0, 617
Telemetry [baseline] (8.44 ms) : 0, 8440
Telemetry [candidate] (8.573 ms) : 0, 8573
Flare Poller [baseline] (3.536 ms) : 0, 3536
Flare Poller [candidate] (3.615 ms) : 0, 3615
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 14 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~520986d07b, baseline=1.59.0-SNAPSHOT~419da213f7
dateFormat X
axisFormat %s
section baseline
no_agent (18.423 ms) : 18225, 18621
. : milestone, 18423,
appsec (19.644 ms) : 19446, 19842
. : milestone, 19644,
code_origins (17.927 ms) : 17749, 18106
. : milestone, 17927,
iast (17.746 ms) : 17570, 17921
. : milestone, 17746,
profiling (19.561 ms) : 19362, 19760
. : milestone, 19561,
tracing (17.567 ms) : 17393, 17741
. : milestone, 17567,
section candidate
no_agent (18.455 ms) : 18266, 18643
. : milestone, 18455,
appsec (18.59 ms) : 18398, 18781
. : milestone, 18590,
code_origins (17.883 ms) : 17704, 18062
. : milestone, 17883,
iast (17.653 ms) : 17480, 17826
. : milestone, 17653,
profiling (21.049 ms) : 20839, 21258
. : milestone, 21049,
tracing (17.614 ms) : 17438, 17791
. : milestone, 17614,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~520986d07b, baseline=1.59.0-SNAPSHOT~419da213f7
dateFormat X
axisFormat %s
section baseline
no_agent (1.178 ms) : 1167, 1190
. : milestone, 1178,
iast (3.159 ms) : 3119, 3198
. : milestone, 3159,
iast_FULL (5.961 ms) : 5902, 6020
. : milestone, 5961,
iast_GLOBAL (3.661 ms) : 3608, 3715
. : milestone, 3661,
profiling (2.065 ms) : 2048, 2083
. : milestone, 2065,
tracing (1.78 ms) : 1765, 1795
. : milestone, 1780,
section candidate
no_agent (1.171 ms) : 1160, 1183
. : milestone, 1171,
iast (3.115 ms) : 3075, 3156
. : milestone, 3115,
iast_FULL (5.798 ms) : 5740, 5856
. : milestone, 5798,
iast_GLOBAL (3.436 ms) : 3387, 3484
. : milestone, 3436,
profiling (2.169 ms) : 2149, 2189
. : milestone, 2169,
tracing (1.756 ms) : 1742, 1770
. : milestone, 1756,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~520986d07b, baseline=1.59.0-SNAPSHOT~419da213f7
dateFormat X
axisFormat %s
section baseline
no_agent (14.593 s) : 14593000, 14593000
. : milestone, 14593000,
appsec (14.485 s) : 14485000, 14485000
. : milestone, 14485000,
iast (17.752 s) : 17752000, 17752000
. : milestone, 17752000,
iast_GLOBAL (17.232 s) : 17232000, 17232000
. : milestone, 17232000,
profiling (14.072 s) : 14072000, 14072000
. : milestone, 14072000,
tracing (13.964 s) : 13964000, 13964000
. : milestone, 13964000,
section candidate
no_agent (15.068 s) : 15068000, 15068000
. : milestone, 15068000,
appsec (14.189 s) : 14189000, 14189000
. : milestone, 14189000,
iast (17.272 s) : 17272000, 17272000
. : milestone, 17272000,
iast_GLOBAL (17.328 s) : 17328000, 17328000
. : milestone, 17328000,
profiling (14.845 s) : 14845000, 14845000
. : milestone, 14845000,
tracing (14.065 s) : 14065000, 14065000
. : milestone, 14065000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~520986d07b, baseline=1.59.0-SNAPSHOT~419da213f7
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (2.798 ms) : 2713, 2883
. : milestone, 2798,
iast (2.575 ms) : 2473, 2678
. : milestone, 2575,
iast_GLOBAL (2.634 ms) : 2532, 2736
. : milestone, 2634,
profiling (2.414 ms) : 2327, 2502
. : milestone, 2414,
tracing (2.379 ms) : 2295, 2463
. : milestone, 2379,
section candidate
no_agent (1.484 ms) : 1472, 1496
. : milestone, 1484,
appsec (4.211 ms) : 3956, 4466
. : milestone, 4211,
iast (2.579 ms) : 2478, 2681
. : milestone, 2579,
iast_GLOBAL (2.638 ms) : 2536, 2741
. : milestone, 2638,
profiling (2.412 ms) : 2325, 2498
. : milestone, 2412,
tracing (2.379 ms) : 2295, 2464
. : milestone, 2379,
|
bric3
approved these changes
Jan 8, 2026
...tooling/src/main/java25/datadog/trace/agent/tooling/servicediscovery/MemFDUnixWriterFFM.java
Outdated
Show resolved
Hide resolved
...tooling/src/main/java25/datadog/trace/agent/tooling/servicediscovery/MemFDUnixWriterFFM.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Avoid early resolving method handles for the FFM memfd writer in order not to impact the startup time.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]