Gate remote agent registry on vsock by resolved agent version - #3335
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intoAug 7, 2026
Merged
Conversation
RAR gained AF_VSOCK support in DataDog/datadog-agent#54474 (agent 7.83), so the `DD_REMOTE_AGENT_REGISTRY_ENABLED=false` override forced by `UseVSock` is no longer needed and can be removed. Note: rollout to vsock clusters should wait until they're running an agent build with the vsock fix, otherwise older agents will crash-loop with RAR enabled.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c45ecb5de5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
Only drop the DD_REMOTE_AGENT_REGISTRY_ENABLED=false override when the node agent's resolved image tag is 7.83+, since RAR's AF_VSOCK support (DataDog/datadog-agent#54474) only ships from that version. Operator and agent versions can be upgraded independently, so the override can't be dropped unconditionally without risking a crash-loop on older agents.
rahulkaukuntla
changed the title
Mathew-Estafanous
approved these changes
Aug 6, 2026
Mathew-Estafanous
left a comment
Mathew-Estafanous
left a comment
Contributor
There was a problem hiding this comment.
one small nit, but everything else looks good
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: waiting
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
rahul.kaukuntla/enable-rar-vsock
branch
August 7, 2026 00:58
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Instead of unconditionally dropping the
DD_REMOTE_AGENT_REGISTRY_ENABLED=falseoverride on vsock clusters, only drop it when the node agent's resolved image tag is7.83+.Motivation
RAR's AF_VSOCK support (DataDog/datadog-agent#54474) only ships from agent 7.83. Since customers can upgrade the operator and agent versions independently, there's no point at which the operator can assume the agent is 7.83+ — so the override must stay version-gated rather than removed outright, or older agents on vsock clusters would crash-loop.
Describe how you validated your changes
Added test cases covering both below- and at-minimum-version scenarios;
go test ./internal/controller/datadogagent/...passes.