chore: upgrade projen to 0.101.20 and opt back in to the system shell - #646
Open
lym953 wants to merge 1 commit into
Open
chore: upgrade projen to 0.101.20 and opt back in to the system shell#646lym953 wants to merge 1 commit into
lym953 wants to merge 1 commit into
Conversation
The weekly `upgrade` workflow has been failing since projen 0.101.20 was released: projen 0.101.0 made its built-in cross-platform shell the default for all task commands, conditions and `$(...)` env-var evaluation, and the projen-generated `PATH: $(yarn exec node --print process.env.PATH)` env var cannot resolve `yarn`/`node` under it, so `yarn projen` dies with `dax: node: command not found`. Take the opt-out documented in the 0.101.0 release notes: `project.tasks.shell = TaskShell.system()`. While pinning the new version, four options in .projenrc.js turned out to have been removed from projen's API. Because .projenrc.js is plain JS, unknown options are silently dropped rather than raising an error, so they were being ignored: - `npmignore` -> `npmIgnoreOptions.ignorePatterns` (all custom .npmignore entries had disappeared) - `scripts` -> `project.addTask()` (the check-formatting task, used by CI, had disappeared) - `releaseWorkflow: false` -> `release: false` (a release.yml workflow, bump/unbump tasks and a commit-and-tag-version dep had appeared, and upgrade.yml had been renamed to upgrade-main.yml) - `mergify: false` -> `githubOptions.mergify: false` (now defaults to true) `jsiiFqn`, `releaseEveryCommit` and `rebuildBot` are also gone and have no replacement, so they are dropped. projen 0.101 also switched the eslint config to typescript-eslint's `projectService`, which only auto-registers a TypeScript projenrc as a loose file, so `.projenrc.js` is registered explicitly via `allowDefaultProjectFiles`. The tsconfig split (tsconfig.dev.json -> tsconfig.json + test/tsconfig.json, and the jsii `tsc` block -> `tsconfig` + `validateTsconfig`) is projen's new generated layout and has no opt-out. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ava-silver
approved these changes
Jul 27, 2026
| "*.tar.gz", | ||
| "cdk.context.json", | ||
| ], | ||
| npmignore: [ |
Contributor
There was a problem hiding this comment.
💭 maybe we should switch this to be a .ts file such that we catch these errors sooner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Fixes the weekly
upgradeworkflow, failing since projen 0.101.20 shipped withdax: node: command not found.The task bumps
projen(^0.99.52→^0.101.20) then re-runsyarn projen. projen 0.101.0 made its built-in shell the default for task commands and$(...)env vars (deliberate break), and the projen-generatedPATH: $(yarn exec node --print process.env.PATH)can't resolveyarn/nodeunder it.The fix is the documented opt-out —
project.tasks.shell = TaskShell.system()(see projen/projen#4783).Silently-ignored options found along the way
Four options in
.projenrc.jshad been removed from projen's API and silently ignored (plain JS = no type error), so they were quietly doing nothing:npmignorenpmIgnoreOptions.ignorePatterns.npmignoreentries vanishedscriptsproject.addTask(...)check-formattingtask vanished (CI uses it)releaseWorkflow: falserelease: falserelease.yml+bump/unbumptasks appeared;upgrade.ymlrenamedmergify: falsegithubOptions.mergifytruejsiiFqn,releaseEveryCommit,rebuildBotare gone with no replacement — dropped.Other forced changes
.projenrc.jsneedseslint.allowDefaultProjectFilesunder 0.101's newprojectServiceconfig, andtsconfig.dev.json→tsconfig.json+test/tsconfig.jsonis projen's new generated layout (no opt-out).yarn.lockmoves onlyprojen/dax/semver/yargs— no dep bumps ride along.Verification
Locally:
yarn projen upgradeexits 0 (the step that fails onmain);yarn projenidempotent so anti-tamper passes; 240 tests + eslint + formatting clean;compileandpackage:js/python/gopass.package:javauntested — no Maven locally; theintegration-testsjob covers it.🤖 Generated with Claude Code