chore: add synced e2e shared helpers - #625
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 26, 2026
ava-silver
marked this pull request as ready for review
June 26, 2026 21:54
nina9753
reviewed
Jun 29, 2026
Comment on lines
+117
to
+120
| } catch (error) { | ||
| // eslint-disable-next-line no-console | ||
| console.error(`[${label}] query error:`, error); | ||
| } |
Contributor
There was a problem hiding this comment.
Every exception is caught, logged, and the loop continues. This includes 401 Unauthorized and 403 Forbidden so if the test runner has the wrong or missing DATADOG_API_KEY/DATADOG_APP_KEY, this will silently retry before failing with timed out waiting for telemetry. Can we handle known failure a little better so the tests don't take as long to fail/retry issues that need intervention?
Contributor
Author
There was a problem hiding this comment.
agree! i'll update the serverless-ci source of truth and then sync it here and all the other TS repos
nina9753
approved these changes
Jun 29, 2026
nina9753
left a comment
nina9753
left a comment
Contributor
There was a problem hiding this comment.
other than 1 comment it looks good
TalUsvyatsky
added a commit
that referenced
this pull request
Jul 2, 2026
This release includes the following commits: 4778176 Add uk1.datadoghq.com as a supported Datadog site (#629) 24e2b7c chore: add synced e2e shared helpers (#625) 5796e51 ADMS: minor: golang.org/x/net, golang.org/x/sys [examples/lambda] (#610) 5161c51 ADMS: vuln minor upgrades — 7 packages (minor: 3 · patch: 4) [examples/step-functions-typescript-stack] (#616) 8f1fdb7 chore(deps): upgrade dependencies (#609) abdf98a feat: default Lambda layer versions when none provided (#623) 62adf03 chore: update year (#624) 61564e3 ADMS: golang.org/x/sys (minor → v0.46.0) [examples/go-stack] (#613) de1ced3 ADMS: golang.org/x/sys (minor → v0.46.0) [examples/step-functions-go-stack] (#612) 2f18058 ADMS: golang.org/x/sys (minor → v0.46.0) [examples/ecs] (#614) 228b82c ADMS: golang.org/x/sys (minor → v0.46.0) [integration_tests/stacks] (#611) 1f86ecb chore(deps): upgrade dependencies (#608) a6645dd chore: Release v2-4.1.0 (#604) df31444 Add ruby 4 (#603) 09b0213 chore: Release v2-4.0.0 (#602) 0b601b7 fix!: Update tag setting to use addEnvironment for CDK 2.253.0 (#601) 59fdd97 Executing automated changes (#585) e36373b chore: Update CODEOWNERS (#590) d996e79 chore: drop node 20, add node 26 to CI matrix, bump min node to 22 (#595) 155fe53 Executing automated changes (#584) 23a6588 chore: Release v2-3.12.0 (#593) 1f7ae00 Executing automated changes (#587) 2e86385 Executing automated changes (#588) 55f5733 Add us2.ddog-gov.com site (#592) e2f1eef chore(deps): upgrade dependencies (#591) e7fb9d3 chore: bump go examples to datadog-cdk-constructs-go v3 (#589) 762ef11 chore(deps): runtime go runtime go1.25.7 → go1.26.2 [examples/lambda/go] (#583) 72701e4 chore: fix release process (#582) 734e7b4 chore: Release v2-3.11.0 (#581) 92be561 chore(deps): upgrade dependencies (#580) e76461b chore(deps): minor: com.datadoghq:datadog-cdk-constructs, software.amazon.awscdk:aws-cdk-lib [examples/java-stack] (#569) d2969e5 chore(deps): eol minor: github.com/DataDog/datadog-lambda-go, github.com/aws/aws-lambda-go, gopkg.in/DataDog/dd-trace-go.v1 [examples/lambda] (#575) b8a4836 feat(ecs): add apiKeySecretField for Secrets Manager API key selection (#578) f7bae33 fix: fix upgrade workflow broken by yarn berry migration (#579) 1332f72 chore: [SVLS-8827] upgrade to yarn berry and add npm minimal age gate (#577) a3cd4b0 Executing automated changes (#574) 350a83f chore(deps): minor: aws-cdk · patch: @types/node [examples/typescript-stack] (#576) b3fce9d chore: remove axios node lambda example in favor of native fetch (#573) 949e1f0 chore: Replace npx with yarn in CI to prevent supply chain attacks (#565) 65891fe chore: [SECURITY] make yarn installs immutable in CI (#564) fe9d5df chore: Release v2-3.10.0 (#563) f5d7002 fix: set DD_TRACE_CLOUD_PAYLOAD_TAGGING env vars to '' instead of $.* by default (#562) cc3b323 chore: [Security] Pin GitHub Actions to a full-length commit SHA (#560) ac4f865 Executing automated changes (#558) 10a24c0 Executing automated changes (#556) 45b9e5d Executing automated changes (#557) 70d9a18 Executing automated changes (#550) dbfe6ef Executing automated changes (#549) f69edaf Executing automated changes (#552) b9602c8 Executing automated changes (#554) 203b5cc Executing automated changes (#548) 8ff27cb chore(deps): upgrade dependencies (#547) 341dc20 Executing automated changes (#545) b06e767 Executing automated changes (#546) fc1c0c8 Executing automated changes (#543) 013dc8c Executing automated changes (#542) 09f4d41 Executing automated changes (#540) ae47440 Executing automated changes (#541) 46ec20d chore: npx projen upgrade (#539) ac494ba Ensure reasonable layer version defaults and links (#538) 529e119 chore: Release v2-3.9.0 (#537) 1e6cdc7 feat: grant decrypt permissions for encryption secrets passed to apiKeySecret (#525) 3ccaa47 chore(deps): upgrade dependencies (#536) 353b31e chore: Release v2-3.8.0 (#532) dc06828 feat: ECS Explorer Configuration (#533) 58b26a2 chore(deps): upgrade dependencies (#531) 6c96a0c Added a shortlink to the ExtensionLayerVersion release page (#485) 143f84e feat: Add DD_API_KEY_SSM_ARN suport for AWS lambda (#527) d1ebcda chore: Release v2-3.7.0 (#530) 6779681 Add support for .NET 10 (#529) 0b90f67 chore(deps): upgrade dependencies (#526) 2bab6dd Revert "Add DD_API_KEY_SSM_ARN suport for AWS lambda" 028dbfa Add DD_API_KEY_SSM_ARN suport for AWS lambda 3c121bb chore: Remove CDK v1 from docs (#523) ff1787f chore(deps): upgrade dependencies (#518) 0cce892 chore: fix CI (#524) 63ccb46 chore: deduplicate unit tests (#522) 1331094 chore: use node 20 for min version (#521) 39f8a41 feat: [SVLS-8268] migrate to OIDC auth (#520) 392282d chore: migrate to serverless onboarding managed team (#519) 3e53fe3 chore(deps): upgrade dependencies (#517) fc3e7ce chore: Release v2-3.6.0 (#516) 308dfab chore(deps): upgrade dependencies (#515) e7973ab Support Ruby 3.4 (#513) a290f42 chore: Release v2-3.5.1 (#514) 540b096 chore: Release v2-3.5.0 (#512) 239bb4c Update log source to datadog-agent (#511) 31a9f6e chore: Fix typos using Cursor (#412) c13c962 add java 25 (#508) 9119102 chore(deps): upgrade dependencies (#504) c52adba feat: add java package (#502) 445306d chore: update gitignore (#510) af3a746 Only set AWS_LAMBDA_EXEC_WRAPPER if extension is configured (#509) 4238dda feat: Allow Configurable Logging Definitions for Application Containers (#507) 8e1c606 chore: Release v2-3.4.0 (#506) aa6245c add node 24 runtime (#505) bb6488c Adding Python 3.14 runtiming (#500) 569f810 [CHORE] update CI to node 24 (#503) 44a670a [SVLS-5911] always add DD_ env vars (#501) 69d4399 chore: Release v2-3.3.0 (#499) 7eac3f7 chore(deps): upgrade dependencies (#498) 8d6f0ea feat(ecs_fargate): [CONTP-921] Configure ROFS support for ecs datadog agent (#495) 0c0c0ea chore(deps): bump aws-cdk-lib (#497) 19b2463 chore(deps): upgrade dependencies (#496) 8106944 chore(deps): upgrade dependencies (#494) 9c8fbed Add example of passing in props to ECS Fargate task definition (#491) 2010667 Update README to show all lambda runtimes supported (#492) 8626475 chore(deps): bump brace-expansion in /examples/ecs/typescript-stack (#467) c5b7891 chore(deps): upgrade dependencies (#490) 1f3761c chore(deps): upgrade dependencies (#489) 6d4721c feat(appsec): deprecate enableDatadogASM in favor of datadogAppSecMode (#486) e65cc91 chore(deps): upgrade dependencies (#481) cae484c chore: Update unsupported node version test to not call determineLatestNodeRuntime (#487) 869a5ed chore: Release v2-3.2.2 (#484) 32bdcca feat(CONTP-922): Expose ability to provide custom ecs.FireLenseLogDriver upon log driver creation (#482) b6a0e0f chore(deps): bump axios from 1.8.2 to 1.12.0 in /examples/lambda/node (#480) 9ba1d5e chore(deps): upgrade dependencies (#478) e55135b chore(deps): upgrade dependencies (#477) a8f523e chore(deps): upgrade dependencies (#476) 94d9a75 Add version.json update to create release script (#475) 0f8a632 Release v2-3.2.1 (#474) e5003ae chore: Add create-release script (#473) a63400f chore(deps): upgrade dependencies (#472) 34c7b90 Allow unit tests to run in gitlab (#471) 0caa064 chore(deps): upgrade dependencies (#470)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
First of a 3-PR stack (#625 → #626 → #627) adding a Lambda e2e instrumentation suite. This PR adds the generic, cross-repo e2e helpers under
e2e/helpers/:exec.ts-- promise-based shell exec with retry-on-transient-error support.naming.ts-- run-unique service names, freshness/run-id tag conventions for the cross-repo resource sweeper.lambda-verifier.ts-- parameterized "config present" / "clean end-state" assertions overget-function-configurationandlist-tags.lambda-telemetry-checker.ts-- polls the Datadog API until spans and logs carrying the workload identity appear.Motivation
These files are synced from
serverless-ci/e2e/shared(the source of truth --DO NOT EDIThere). Landing them alone keeps the generated, parameterized primitives separate from this repo's wiring, so the substantive PRs higher in the stack stay readable.Testing Guidelines
No standalone run -- these helpers are exercised by the test suite at the top of the stack (#627). They are marked
linguist-generated(collapsed in diffs) via.gitattributes; review against theserverless-cisource.Additional Notes
Nothing else here is wired up yet; the deps, fixture, and test land in #626 and #627.
Types of Changes
Check all that apply