Repository navigation
Conversation
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Addresses
https://broadworkbench.atlassian.net/browse/DT-4324
Summary
DataAccessRequestDAOTest.testFindApprovedDARsByDatasetIdLastsTheExpirationDurationfailed at times on a local computer. I found the failure during the test runs for #3297.8760, 0set a submission date of exactly 8760 hours before the time of the JVM clock.now()from the database clock.The test now reads
now()from the database and calculates the submission date from that time. Thus the test uses one clock. This changes only test code.This pull request does not depend on the prod upgrade. It can merge now.
Test results
The test passed 3 times on
postgres:16.10-alpineand 3 times onpostgres:18.7-alpine. The failure was not regular, so these runs do not prove the correction. The proof is that the test no longer uses the JVM clock for the date.Have you read CONTRIBUTING.md lately? If not, do that first.
🤖 Generated with Claude Code