chore: delete orphan ReluBall package - #102
Closed
chipcrowd[bot] wants to merge 1 commit into
Closed
Conversation
No Core/Chip maps ReluBall; drop examples/balls/relu and the dead populateReluBallLowerBuckyballToBankSSAPatterns declaration.
Member
|
Toy maintains all balls not maintained by other chips to ensure these balls' functionality. So ReLU ball is still used by Toy. |
Author
|
ack — missed the Toy ownership convention. Toy is the catch-all for leftover balls (not just the three currently listed in Closing this PR; will keep ReluBall and treat leftover-ball packages as live unless Toy drops them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/balls/relu/(no Core/Chip BallDomain mapping; registry never selects it).populateReluBallLowerBuckyballToBankSSAPatternsdeclaration fromcompiler/.../LowerBuckyball.h.Nightly audit trial cleanup area 1 (research-then-spread-out). Pure subtraction.
Test plan
ReluBall/balls/relureferences outside this PRlinalg_relu/int2fp_reluworkloads still present (unrelated)