Repository navigation
Conversation
IsInTMSFull returned false as soon as any one coordinate was inside the TMS box, so it was false both inside the TMS and for most points outside it. Its only caller, the rock-muon definition in EventRates.cxx, therefore never vetoed muons born in the TMS. Require all three coordinates to be in range instead; the box bounds are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsInTMSFull()inscripts/Validation/Tracking_Validation.cpphad its logic inverted. It started fromtrueand setfalseas soon as any one coordinate fell inside the TMS box. It therefore returnedfalsefor points inside the TMS (all three coordinates in range) and also for most points outside it (at least one coordinate in range).Its only caller is the rock-muon definition in
EventRates.cxx:Because
!IsInTMSFull()was true almost everywhere, the TMS veto did nothing. Theevent_rates/rock_muons/*plots were effectively counting every muon born outside the ND-LAr active volume, including muons born inside the TMS.Change
IsInTMSFull()now returnstrueonly when X, Y and Z are all inside the box. The box bounds (mm) are unchanged.Effect
Checked on one MiniProdN5p3 sanddrift v4 file (
...sanddrift.v4.0000001.TMSRECO.root, 9 spills), countingTruth_Spillmuons with each definition:IsInTMSFullIsInTMSFullAbout a third of what the rock-muon plots were counting were muons born inside the TMS. Only the
event_rates/rock_muons/*histograms change. No other code callsIsInTMSFull().