Request-a-copy: Show correct preview link#4134
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Apr 8, 2025
Merged
Conversation
Preview link was showing old URL path in grant access form
tdonohue
approved these changes
Apr 8, 2025
Member
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @kshepherd ! I verified the bug & verified this fixes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preview link was showing an outdated routing path (
/access-by-token) instead of the newer, simple item page path with a query parameter.This small PR fixes that issue and removes some obsolete routing code.
References
List of changes in this PR:
To test, visit the 'grant request' page form with secure links enabled, after requesting an item, and ensure the preview link looks valid (note - it won't work yet as the access hasn't been granted at the time of viewing the form! it's just there for preview / copy paste purposes)
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint