Skip to content

fix(dev): wait for /api/health/ready before reporting local-start ready #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fstagni merged 2 commits into from
Aug 25, 2026
Merged

fix(dev): wait for /api/health/ready before reporting local-start ready #1020

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2e50a9
fix(dev): wait for /api/health/ready in local-start
mmascher Aug 24, 2026
dd93ad3
Use curl and not wget
mmascher Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions run_local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ function wait_for_service() {
}

function redis_ready() { redis-cli -p 6379 ping 2>/dev/null | grep -q PONG; }
function diracx_ready() { curl --silent --show-error --fail --output /dev/null --max-time 2 http://localhost:8000/api/health/ready; }

# Make a keystore
keystore="${tmp_dir}/keystore/jwks.json"
Expand Down Expand Up @@ -217,9 +218,9 @@ function restart_process() {
all_pid_values[$i]=$!
}

# Wait for uvicorn
# Wait for DiracX readiness
if wait_for_service "uvicorn" "$diracx_pid" "${tmp_dir}/logs/uvicorn.log" \
curl --silent --max-time 2 --head http://localhost:8000; then
diracx_ready; then
status_line="✅ DiracX is running on http://localhost:8000"
else
status_line="❌ Failed to start DiracX — check ${tmp_dir}/logs/uvicorn.log"
Expand Down
Loading