refactor: theme typing, error UX, a11y, lint config, dev hygiene - #499
Merged
Conversation
aldbr
force-pushed
the
split/5-quality-hygiene
branch
from
July 14, 2026 13:11
c37266b to
636ba2f
Compare
Contributor
Author
aldbr
force-pushed
the
split/5-quality-hygiene
branch
7 times, most recently
from
July 15, 2026 07:14
92a433f to
184c2a6
Compare
Quality and hygiene follow-ups across the workspace: - ThemeProvider: introduce a ThemeMode union with a type-guarded sessionStorage read, keep render pure (storage is only written on an explicit user toggle), memoize toggleTheme, and derive outlined-input border/label colors for both palette modes; Dashboard tests updated for the new persistence semantics - eslint flat configs (components, app, extensions) tightened, notably enabling eslint-plugin-jsx-a11y; the intentional autoFocus in the drawer rename fields gains documented disable directives - README refreshed
aldbr
force-pushed
the
split/5-quality-hygiene
branch
from
August 18, 2026 11:07
184c2a6 to
bfd86c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #494 (stack 5/5, final). Stacked on #498 — until it merges, review the last commit only (
refactor:).Quality and hygiene tail of the stack:
ThemeMode = "light" | "dark"union replacesstring | null(casts gone); render is pure —sessionStoragewrites move out of the render phase; storage now records only explicit user choices, making the follow-system-preference branch reachable; dark mode gets palette-aware focused-input colors (previously hardcoded light-mode greys/black);eslint-plugin-jsx-a11y(recommended) enabled on the components package — where all the interactive UI lives (0 errors after the a11y fixes earlier in the stack); prettier-conflicting formatting rules (indent,semi,comma-dangle) removed from the app/extension configs;After this merges, the stack tree is identical to the original development branch — closes out #494's implementation phase.
🤖 Generated with Claude Code