ci: add upgrade-path regression test - #266
Open
chrisburr wants to merge 1 commit into
Open
Conversation
chrisburr
marked this pull request as ready for review
April 28, 2026 15:09
Install the latest released chart, then helm upgrade --atomic to the PR's working-tree chart, on a kind cluster. Catches the class of bug where a chart change that's harmless on a fresh install breaks the upgrade path — e.g. PR #262 converting diracx-secrets from a regular resource to a hook, which silently deleted the Secret during upgrades from <= 1.0.x. The job reuses the released-tag's own run_demo.sh via 'git worktree add' so the install step is coherent with that chart version (its own demo/values.tpl.yaml etc.). After the install, --atomic upgrade runs against the PR tree; assertions check helm release status, key release resources still exist, all pods Ready, no failed hook Jobs, helm history advanced. Diagnostics always run. Skips cleanly when there's no prior release, when Chart.yaml version is unchanged, or when the PR is docs-only.
aldbr
force-pushed
the
ci-upgrade-path-test
branch
from
April 29, 2026 15:25
580da64 to
5d04f8a
Compare
aldbr
reviewed
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install the latest released chart, then helm upgrade --atomic to the PR's working-tree chart, on a kind cluster. Catches the class of bug where a chart change that's harmless on a fresh install breaks the upgrade path — e.g. PR #262 converting diracx-secrets from a regular resource to a hook, which silently deleted the Secret during upgrades from <= 1.0.x.
The job reuses the released-tag's own run_demo.sh via 'git worktree add' so the install step is coherent with that chart version (its own demo/values.tpl.yaml etc.). After the install, --atomic upgrade runs against the PR tree; assertions check helm release status, key release resources still exist, all pods Ready, no failed hook Jobs, helm history advanced. Diagnostics always run.
Skips cleanly when there's no prior release, when Chart.yaml version is unchanged, or when the PR is docs-only.