Skip to content

Make genericOptions a list - #285

Merged
fstagni merged 1 commit into
DIRACGrid:develfrom
maxnoe:generic-option-list
Aug 25, 2026
Merged

Make genericOptions a list#285
fstagni merged 1 commit into
DIRACGrid:develfrom
maxnoe:generic-option-list

Conversation

@maxnoe

@maxnoe maxnoe commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown

This fixes that only the last -o option takes effect for the pilot.

Fixes #284

Disclaimer: changes made by Codex, I reviewed and take responsibility for the proposed changes.

@aldbr
aldbr requested a review from fstagni August 25, 2026 14:56
@maxnoe
maxnoe force-pushed the generic-option-list branch from f9fa731 to 900181d Compare August 25, 2026 15:03
@fstagni
fstagni changed the base branch from master to devel August 25, 2026 15:08
@maxnoe
maxnoe force-pushed the generic-option-list branch from 900181d to 936c2e1 Compare August 25, 2026 15:09
@maxnoe
fix: Make genericOptions a list
e4ad61d 
This fixes that only the last `-o` option takes effect for the pilot.
@maxnoe
maxnoe force-pushed the generic-option-list branch from 936c2e1 to e4ad61d Compare August 25, 2026 15:10
@maxnoe

maxnoe commented Aug 25, 2026

Copy link
Copy Markdown
Author

I'm a bit confused about the branches, you changed to devel but devel is actually behind master? Usually it's the other way around...

@fstagni

fstagni commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

I'm a bit confused about the branches, you changed to devel but devel is actually behind master? Usually it's the other way around...

We always merge first in devel, which is what runs in the certification setup. And yes of course devel should be ahead of master, but right now for whatever reason there was a commit only in master about the retention-days ("nightly").

Anyway, now I merge it. Tomorrow I will test in certification before merging it in master

@fstagni
fstagni merged commit c05b7f9 into DIRACGrid:devel Aug 25, 2026
8 checks passed
@maxnoe

maxnoe commented Aug 25, 2026

Copy link
Copy Markdown
Author

ah, ok, thanks for the clarification

@maxnoe
maxnoe deleted the generic-option-list branch August 25, 2026 15:19
@maxnoe maxnoe mentioned this pull request Aug 27, 2026
Closed
1 task
@fstagni

fstagni commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

FYI: integration tests failed for LHCb only. I applied a backword-compatibility fix to LHCbPilot and will go in prod with that before merging this in master (so, production)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fstagni fstagni fstagni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: genericOptions should be a list of options but only last given option takes effect

2 participants

@maxnoe @fstagni