Fix: per-token error handling in EVM balance queries#3666
Open
TaprootFreak wants to merge 1 commit intodevelopfrom
Open
Fix: per-token error handling in EVM balance queries#3666TaprootFreak wants to merge 1 commit intodevelopfrom
TaprootFreak wants to merge 1 commit intodevelopfrom
Conversation
A single failing token (e.g. broken decimals() call) in getTokenBalances could abort the entire loop, preventing balance updates for all tokens on that chain. Wrap each token iteration in try/catch so other tokens continue processing when one fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTokenBalances()(e.g. brokendecimals()call) could abort the entire loop, preventing balance updates for all tokens on that chainevm-client.tsandcitrea-base-client.tsso other tokens continue processing when one failsContext
Investigation of BBTC (Asset 394) plus balance showing 0.001 instead of 1.73 BBTC (on-chain). The
liquidity_balancehasn't been updated since 2026-04-30 despite the cron running every minute. Production logs show no Ethereum-specific errors, pointing to either an Alchemy indexing lag or a silent token processing failure that goes unlogged due to missing error handling in the loop.Test plan