fix: mail skip semantics + PersonalMail wallet alignment#3657
Merged
TaprootFreak merged 2 commits intodevelopfrom Apr 30, 2026
Merged
fix: mail skip semantics + PersonalMail wallet alignment#3657TaprootFreak merged 2 commits intodevelopfrom
TaprootFreak merged 2 commits intodevelopfrom
Conversation
|
F2: Skipped RealUnit mails no longer set recipientMail — only mailSendDate is written to prevent re-processing. New entity methods skipMail(), skipPendingMail(), skipChargebackMail() replace the incorrect use of confirmSentMail()/pendingMail()/chargebackMail() in skip paths. F10: createPersonalMail now respects walletMailConfig.forcedLang and passes walletName to translate() and getMailAffix(), consistent with createUserV2Mail. F6: createPersonalMail now calls getWalletBodyTexts() so wallet-specific body overrides are applied.
6b02d0b to
97f3914
Compare
davidleomay
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes from #3654 (RealUnit Mail PR #3598 follow-ups):
recipientMail— newskipMail()/skipPendingMail()/skipChargebackMail()entity methods only write the date field to prevent re-processing, without implying a mail was sent. Fixes data integrity issue in audit/monitoring.createPersonalMailnow respectsforcedLangfrom wallet config and passeswalletNamethrough the translation chain, consistent withcreateUserV2Mail.createPersonalMailnow callsgetWalletBodyTexts()so wallet-specific body overrides apply.Changed files
buy-crypto.entity.tsskipMail()buy-fiat.entity.tsskipPendingMail(),skipChargebackMail()limit-request.entity.tsskipMail()buy-crypto-notification.service.tsbuy-fiat-notification.service.tslimit-request-notification.service.tsmail.factory.tscreatePersonalMailwithcreateUserV2MailTest plan
recipientMailstays NULL for skipped RealUnit mailsconfirmSentMailetc.)forcedLang, verify correct language is usedCloses #3654 (F2, F6, F10)