Skip to content

fix: distinguish attachment upload and processing states - #694

Merged
chenyme merged 1 commit into
devfrom
upload
Aug 29, 2026
Merged

fix: distinguish attachment upload and processing states#694
chenyme merged 1 commit into
devfrom
upload

Conversation

@chenyme

@chenyme chenyme commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix misleading attachment status feedback in the chat composer.

Document attachments previously reused the primary upload spinner while queued for extraction or vectorization. This made successfully uploaded TXT and PDF files appear to remain stuck in the upload stage.

  • Preserve the file-type icon after the upload request completes.
  • Display queued extraction and vectorization progress with a compact secondary spinner and explicit status text.
  • Reserve the primary spinner for active file transfers.
  • Use the shared isFileProcessing state resolver instead of inferring processing state from presentation tones.
  • Localize the upload status in English and Chinese.
  • Preserve existing upload polling file processing and attachment lifecycle behavior.

Change type

  • Bug fix
  • Feature
  • Documentation
  • Refactor
  • Configuration / deployment
  • Security hardening
  • Other

Affected areas

  • Frontend / UI
  • Backend / API
  • Authentication / authorization
  • Conversations / streaming
  • Files / RAG / extraction
  • Model routing / providers
  • MCP / tools
  • Billing / payments
  • Admin console
  • Deployment / Docker / configuration
  • Documentation

Verification

  • pnpm check
  • pnpm build
  • git diff --check

Screenshots, API examples, or logs

The reported screenshot demonstrates that uploaded document attachments retained the same primary spinner used during file transfer.

No API contract or backend behavior changed.

Configuration, migration, and compatibility notes

  • No configuration changes.
  • No API contract changes.
  • No database migrations.
  • No deployment changes.
  • Existing attachment processing and status polling remain backward compatible.

Documentation

  • Documentation is not needed for this change.
  • Documentation was updated.
  • Documentation still needs to be updated.

Security and privacy

  • No secrets, tokens, credentials, local config, or personal data are included.
  • User data access remains scoped by authenticated user context unless an admin-only path explicitly requires broader access.
  • Security-sensitive behavior was reviewed, including file processing and attachment lifecycle behavior.

Checklist

  • I searched existing issues and pull requests.
  • Changes are focused and do not include unrelated refactors.
  • Tests or static verification were run where practical.
  • User-facing behavior, deployment steps, API contracts, or configuration changes are documented.
  • Generated artifacts are included only when this project explicitly requires them.
  • Caches, build output, .pyc files, .env files, and local storage data are not committed.

@chenyme chenyme self-assigned this Aug 29, 2026
@chenyme chenyme linked an issue Aug 29, 2026 that may be closed by this pull request
3 tasks
@chenyme
chenyme merged commit 059264a into dev Aug 29, 2026
11 checks passed
@chenyme
chenyme deleted the upload branch August 29, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Document attachments keep showing a spinner after upload completes

1 participant