fix: backfill missing XMP sidecars and avoid filename collisions - #1569
Open
TomasVSantos wants to merge 2 commits into
Open
fix: backfill missing XMP sidecars and avoid filename collisions#1569TomasVSantos wants to merge 2 commits into
TomasVSantos wants to merge 2 commits into
Conversation
TomasVSantos
force-pushed
the
tomas/fix-xmp-backfill-collisions
branch
from
August 24, 2026 20:29
39e6310 to
1ea1916
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1556.
When “Create XMP if missing” was enabled after images had already been rated or edited, missing XMP sidecars were not generated. This change backfills missing XMP files from existing
.rrdatasidecars when the setting is enabled.Type of Change
Changes Made
.rrdatafiles and create missing XMP sidecars.Screenshots/Videos
Testing
Test Configuration:
Additional verification:
cargo checkpasses.cargo testpasses; the repository currently contains no automated tests.git diff --checkpass.Checklist
Additional Notes
The new sidecar naming prevents collisions:
IMG_2280.DNG.xmpIMG_2280.jpg.xmpExisting
IMG_2280.xmpfiles are intentionally not migrated.The repository currently has unrelated existing TypeScript and i18n validation errors.
AI Disclaimer: