fix(desktop): keep File > Quit enabled when no document is open (v2.35.1) - #396
Open
CryptoJones wants to merge 1 commit into
Open
fix(desktop): keep File > Quit enabled when no document is open (v2.35.1)#396CryptoJones wants to merge 1 commit into
CryptoJones wants to merge 1 commit into
Conversation
…5.1) The action registry infers each command's prerequisite from its slot's name. Quit's slot is QMainWindow.close, which carries none of the always-on tokens, so it was filed under "document" and greyed out on an empty window. Declare the prerequisite explicitly and pin it with a test. iOS has no Quit item and the CLI has no menu, so no parity work is owed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MBFbbmheMWDuHmUvsh28mn
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QMainWindow.close, which carries none of the always-on tokens, so it was filed under "document" beside Save and Close Tab. The action now declaresprerequisite="always"explicitly.ipados/project.yml2.35.1 / 23501) plus a CHANGELOG entry under Fixed.Parity
iOS has no Quit menu item and the CLI has no menu, so nothing is owed on the other two editions.
Verification
scripts/ci-local.sh pythongates: version check, ruff check + format, mascot check, full pytest (3793 passed, 25 skipped). One version-gate test failed on the first run because the local venv carried stale 2.28.0 package metadata from before this change;uv sync --extra dev --locked --reinstall-package photoslopcleared it and the affected files pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01MBFbbmheMWDuHmUvsh28mn
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/