Skip to content

fix(desktop): keep File > Quit enabled when no document is open (v2.35.1) - #396

Open
CryptoJones wants to merge 1 commit into
mainfrom
fix/quit-enabled-without-document
Open

fix(desktop): keep File > Quit enabled when no document is open (v2.35.1)#396
CryptoJones wants to merge 1 commit into
mainfrom
fix/quit-enabled-without-document

Conversation

@CryptoJones

Copy link
Copy Markdown
Owner

Summary

  • File ▸ Quit was greyed out on the desktop whenever no document was open. The action registry infers each command's prerequisite from its slot's name; Quit's slot is QMainWindow.close, which carries none of the always-on tokens, so it was filed under "document" beside Save and Close Tab. The action now declares prerequisite="always" explicitly.
  • Regression test holds Quit enabled on an empty window and after a document opens.
  • Version 2.35.1 across every declaration the version gate tracks (about file, README badge, docs, ipados/project.yml 2.35.1 / 23501) plus a CHANGELOG entry under Fixed.

Parity

iOS has no Quit menu item and the CLI has no menu, so nothing is owed on the other two editions.

Verification

scripts/ci-local.sh python gates: version check, ruff check + format, mascot check, full pytest (3793 passed, 25 skipped). One version-gate test failed on the first run because the local venv carried stale 2.28.0 package metadata from before this change; uv sync --extra dev --locked --reinstall-package photoslop cleared it and the affected files pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MBFbbmheMWDuHmUvsh28mn

Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/

…5.1)

The action registry infers each command's prerequisite from its slot's
name. Quit's slot is QMainWindow.close, which carries none of the
always-on tokens, so it was filed under "document" and greyed out on an
empty window. Declare the prerequisite explicitly and pin it with a test.

iOS has no Quit item and the CLI has no menu, so no parity work is owed.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MBFbbmheMWDuHmUvsh28mn
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: e2670165-d2c6-4b9f-9e6b-74083db48c47


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant