acp: select a reject option on permission requests; cancel only without options - #63
Open
CryptoJones wants to merge 1 commit into
Open
acp: select a reject option on permission requests; cancel only without options#63CryptoJones wants to merge 1 commit into
CryptoJones wants to merge 1 commit into
Conversation
…ut options (#62) "cancelled" means the user cancelled the turn, and agents honour it: Laguna's first delivered full-brief turn (506s, post-#61) ended after one sentence on exactly that reply. With options present the client now selects a reject-kind option -- denied, carry on -- falling back to cancelled only when the request carries none. 123 tests pass (1 new). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VmauK5UCYGRYyXoQ36FQ3S
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62. Follow-up to #61, found on the first delivered CmdrData full-brief turn: the turn completed (506.1s, exit 0 — the #56 stall is gone) but the answer was one sentence, because our
cancelledreply to its permission request read as "the user cancelled the turn" (pool-acp log:permission request cancelledat 19:29:22, then wrap-up). ACP permission requests carry an options list; the client now selects a reject-kind option ("denied, carry on") and falls back tocancelledonly when no options are present. One new test; 123 pass.Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/
🤖 Generated with Claude Code
https://claude.ai/code/session_01VmauK5UCYGRYyXoQ36FQ3S