fix: a roster with no active lanes must not exit 0 - #40
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
`0/0 lanes answered` returned success. len(answered) == len(results) is true of two empty lists, so a config with every lane parked reported a clean run having asked nobody anything. That is the same shape as partial delivery, which this tool deliberately treats as failure -- a lane that silently did not run. In a cron or CI context the exit code is the only signal anyone reads, so the one case that should shout was the one case that was quiet. --list stays exit 0 with an empty roster: "what is configured" is a fair question even when the answer is none. Closes #26 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014kR9wKwm5sgUQSs5uxbAzv
CryptoJones
force-pushed
the
fix/no-active-lanes-fails
branch
from
August 26, 2026 17:35
ba6f5af to
050c76c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26.
len(answered) == len(results)is true of two empty lists, so a config withevery lane parked reported a clean run having asked nobody anything.
That's the same shape as partial delivery, which this tool deliberately treats
as failure — a lane that silently did not run. And in a cron or CI context the
exit code is the only signal anyone reads, so the one case that should shout was
the one case that was quiet.
Now:
--liststays exit 0 with an empty roster — "what is configured" is a fairquestion even when the answer is none.
Tests
62, up from 60. Two new: the run fails and names the cause, and
--liststillsucceeds on the same config.
CI
GitHub Actions still in major outage. Local equivalent:
LOCAL CI EQUIVALENT: PASS. Holding the merge.Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/