Skip to content

fix: a roster with no active lanes must not exit 0 - #40

Merged
CryptoJones merged 1 commit into
mainfrom
fix/no-active-lanes-fails
Aug 26, 2026
Merged

fix: a roster with no active lanes must not exit 0#40
CryptoJones merged 1 commit into
mainfrom
fix/no-active-lanes-fails

Conversation

@CryptoJones

Copy link
Copy Markdown
Owner

Closes #26.

==========================================================================
0/0 lanes answered in 0.0s
$ echo $?
0

len(answered) == len(results) is true of two empty lists, so a config with
every lane parked reported a clean run having asked nobody anything.

That's the same shape as partial delivery, which this tool deliberately treats
as failure — a lane that silently did not run. And in a cron or CI context the
exit code is the only signal anyone reads, so the one case that should shout was
the one case that was quiet.

Now:

roundtable: <config> has lanes, but none are active — set active: true on at least one
exit=1

--list stays exit 0 with an empty roster — "what is configured" is a fair
question even when the answer is none.

Tests

62, up from 60. Two new: the run fails and names the cause, and --list still
succeeds on the same config.

CI

GitHub Actions still in major outage. Local equivalent:
LOCAL CI EQUIVALENT: PASS. Holding the merge.

Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 97c2d946-d6d8-47f5-b6b6-dffc9f04d511


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

`0/0 lanes answered` returned success. len(answered) == len(results) is true of
two empty lists, so a config with every lane parked reported a clean run having
asked nobody anything.

That is the same shape as partial delivery, which this tool deliberately treats
as failure -- a lane that silently did not run. In a cron or CI context the exit
code is the only signal anyone reads, so the one case that should shout was the
one case that was quiet.

--list stays exit 0 with an empty roster: "what is configured" is a fair
question even when the answer is none.

Closes #26

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014kR9wKwm5sgUQSs5uxbAzv
@CryptoJones
CryptoJones force-pushed the fix/no-active-lanes-fails branch from ba6f5af to 050c76c Compare August 26, 2026 17:35
@CryptoJones
CryptoJones merged commit 6b63516 into main Aug 26, 2026
5 checks passed
@CryptoJones
CryptoJones deleted the fix/no-active-lanes-fails branch August 26, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A config with zero active lanes exits 0 claiming success

1 participant