Respect SSL verification settings#44
Open
c-kr wants to merge 1 commit intoConSol-Monitoring:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VSAN SSL Verification
Summary
This patch makes
vsanrespect-nossl/--disable-ssl-verification.The initial vCenter connection already respects
-nossl. This fix applies to thesecondary vSAN API context created for
vsu.GetVsanVcMos().Before this fix, that secondary vSAN API context disabled certificate verification
unconditionally. After the fix:
-nossldisables hostname and certificate checksFiles
checkvsphere/vcmd/vsan.pyQuick Verification
Use an environment where the initial vCenter connection succeeds without
-nossl, so the command reaches the secondary vSAN API context.Expected before fix:
Expected after fix:
-nosslis addedThen verify the opt-out path explicitly:
Expected after fix:
-nosslwas supplied