fix(types): validate auth token responses#828
Open
open-inspect[bot] wants to merge 1 commit into
Open
Conversation
Terraform Validation Results
Pushed by: @open-inspect[bot], Action: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated nightly unsafe-cast remediation. It replaces selected high-risk TypeScript assertions at OAuth/API trust boundaries with Zod
safeParsevalidation, following the TypeScript Coding Standards unsafe-cast / parse-don't-assert guidance and the Zod boundary-validation pattern established in PR #807.packages/control-plane/src/auth/github.ts:48(await response.json()) as GitHubTokenResponse & { error?: string; error_description?: string }for GitHub OAuth code exchangegithubTokenResponseSchemaas theGitHubTokenResponsesource of truth and parse throughparseGitHubTokenResponsewith preserved OAuth error handlingpackages/control-plane/src/auth/github.ts:81(await response.json()) as GitHubTokenResponse & { error?: string; error_description?: string }for GitHub OAuth refreshgithubTokenResponseSchema.safeParseat the refresh boundarypackages/control-plane/src/auth/openai.ts:50response.json() as Promise<OpenAITokenResponse>for OpenAI OAuth refreshopenAITokenResponseSchema/z.inferand validate the parsed response before returningVerification:
npm test -w @open-inspect/control-plane -- src/auth/github.test.ts src/auth/openai.test.tsnpm run build -w @open-inspect/sharednpm run build -w @open-inspect/control-planenpm run typechecknpm run lint.opencode/tooling directory out of the workspace so the root lint command evaluated tracked repository filesnpm run formatnpm test -w @open-inspect/control-planeCreated with Open-Inspect