fix: general quality of service improvements#167
Conversation
096a4ab to
84220b8
Compare
There was a problem hiding this comment.
Bug: CopyWith Mutates Original MultipartRequest Files
The MultipartRequest.copyWith method calls file.finalize() on the original MultipartFile objects. Since finalize() consumes the file's stream and can only be called once, this makes the original request's files unusable and can result in the copied request having invalid or empty file contents if the originals were already finalized. This violates the non-mutating behavior expected from copyWith().
lib/extensions/multipart_request.dart#L25-L44
http_interceptor/lib/extensions/multipart_request.dart
Lines 25 to 44 in 7a57b40
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
‼ This one might get superseeded by #173 since I'd rather improve the rebuilt version than keep fixing issues on 2.x versions. The factor of time that I can spend working on this is also a factor for that. |
No description provided.