🐛 fix(ci): use admin:admin in DAST auth to match qa-compose hash#403
Merged
Conversation
Root cause of the recurring DAST 401: the two "Create ZAP/Nuclei authenticated session" steps hardcoded admin:password, but test/qa-compose.yml's DD_AUTH_BASIC_ADMIN_HASH verifies the plaintext 'admin' (not 'password'). The previous fix in #402 (health readiness gate) was real and is still needed, but the 401 we kept chasing was simpler: invalid credentials. Why this was confusing: - test/ci-compose.yml (used by Load Tests) uses a different hash that DOES verify 'password', so the load tests passed with admin:password - test/qa-compose.yml (used by DAST AND Playwright) uses a hash that verifies 'admin', and Playwright already defaults to admin:admin via e2e/playwright/helpers/test-helpers.ts:19-22, so Playwright passed - Only DAST was sending the wrong credential, and only DAST failed Fix changes both auth steps from admin:password to admin:admin and documents the divergence between qa-compose and ci-compose hashes inline so this doesn't trip the next person.
s-b-e-n-s-o-n
requested review from
ALARGECOMPANY and
biggest-littlest
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
biggest-littlest
approved these changes
May 29, 2026
Member
biggest-littlest
left a comment
biggest-littlest
left a comment
There was a problem hiding this comment.
LGTM — minimal credential fix, well-documented. Matches Playwright's existing admin:admin convention against the same qa-compose.
ALARGECOMPANY
approved these changes
May 29, 2026
Member
ALARGECOMPANY
left a comment
ALARGECOMPANY
left a comment
There was a problem hiding this comment.
Approved. Confirmed qa-compose vs ci-compose hash divergence is real; this aligns DAST with the qa-compose contract.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The recurring DAST 401 we've been chasing was caused by invalid credentials, not the readiness race PR #402 fixed.
test/qa-compose.ymlDD_AUTH_BASIC_ADMIN_HASHverifies the plaintext `admin`, not `password`test/ci-compose.yml(used by Load Tests) uses a different hash that verifies `password`PR #402's readiness gate is still correct and required: the CI log for run 26611307727 shows `Wait for QA health` passed at 01:13:10.207Z and Basic strategy registered at 01:13:09.763Z — strategies were registered before the failed request. The 401 was just bad credentials.
Changes
Test plan