Reference Clickhouse credentials in secret#161
Reference Clickhouse credentials in secret#161namm2 wants to merge 7 commits intoClickHouse:mainfrom
Conversation
Signed-off-by: Nam Hai Nguyen <[email protected]>
Signed-off-by: Nam Hai Nguyen <[email protected]>
|
Could we also please add the clickhouse user's password to be referenced from a secret |
I think this is a different use case |
dhable
left a comment
There was a problem hiding this comment.
Thanks for the contribution. There's a merge conflict, probably around the version, that needs to be resolved. If you revert the Chart.yaml change, it should allow merging in main into your PR branch.
We also would like a changeset in the PR as well. You can create this by running yarn install from the root to install the changeset CLI. Then run yarn changeset and follow the prompts to generate the required files. We can't generate a release without that.
Signed-off-by: Nam Hai Nguyen <[email protected]>
🦋 Changeset detectedLatest commit: b589c94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Nam Hai Nguyen <[email protected]>
|
@namm2 There are some unit tests that are now failing because the rendered template is different. Can you fix up the assertions please? |
Signed-off-by: Nam Hai Nguyen <[email protected]>
Use
secretKeyRefto not expose Clickhouse credentials into runtime environment