Conversation
|
Instead of adding another prop here, I would consider inversion of control https://kentcdodds.com/blog/inversion-of-control |
josh-clever
left a comment
There was a problem hiding this comment.
Not going to block on the extra prop, but I think it would be interesting to explore a solution where we don't have to add an extra prop.
Thanks for sharing that article. I agree that adding an extra prop isn't the ideal solution. If we applied the principles from the article, we could have say a I might not need this change, so I may close this pull request, but it's good to think about how we might make the API more flexible for the future. |
Overview:
This change lets us use any button type for the
WizardLayout's next button. I saw a couple of cases in some of our design mocks where thesecondarybutton type is used. I'm not sure if we'd ever actually use the other button types, but they'll be there if we want them.Screenshots/GIFs:

Here's an example of a design mock that uses a
secondarybutton type for the next button.Testing:
Roll Out:
package.jsonnpm version majornpm version minorComponentsView.jsx. To do so:ComponentsView.componentsToDisplayusing this template:docs/assets/imgwith the format<COMPONENT LINK>.pngmake deploy-docs)