fix: multiple bug fixes across rerankings, indexing, config and app - #850
Open
praneshnikhar wants to merge 1 commit into
Open
praneshnikhar wants to merge 1 commit into
praneshnikhar wants to merge 1 commit into
Conversation
- Fix return-inside-for-loop bug in rerankings/ui.py that caused only the first vendor parameter to be processed (copy-paste error) - Fix undefined variable error in index/file/ui.py (errors -> index_errors) - Fix bool casting in flowsettings.py where python-decouple's cast=bool parsed 'False'/'0'/'no' as True for GraphRAG flags - Fix GRADIO_TEMP_DIR empty-string edge case in app.py - Fix hardcoded relative asset path in app.py using Path(__file__) - Make inbrowser launch configurable via KH_OPEN_BROWSER env var
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 6 bugs found during code review:
Return-inside-for-loop in
rerankings/ui.py— Thereturnwasinside the
forloop, so only the first vendor parameter was everprocessed (copy-paste error from
embeddings/ui.py).Undefined variable in
index/file/ui.py—errorswas neverdefined; should be
index_errors(fromStopIteration.value).Crashed whenever the indexing generator finished.
boolcasting bug inflowsettings.py—python-decouple'scast=booltreated any non-empty string (including"False","0","no") asTruefor GraphRAG flags.Empty-string
GRADIO_TEMP_DIRinapp.py—os.getenv(..., None)only returned
Nonewhen unset, not when set to"". Downstreamreceived an empty path.
Hardcoded relative asset path in
app.py—"libs/ktem/ktem/assets"broke if CWD != project root. Now resolved via
Path(__file__).inbrowser=Trueon headless servers — Made configurable viaKH_OPEN_BROWSERenv var, defaulting to off.