Skip to content

Comments

print status details while waiting#97

Merged
msherman64 merged 2 commits intomasterfrom
feat/expose_event_details
Feb 19, 2026
Merged

print status details while waiting#97
msherman64 merged 2 commits intomasterfrom
feat/expose_event_details

Conversation

@msherman64
Copy link
Contributor

@msherman64 msherman64 commented Feb 18, 2026

Update the container.wait() callback to print container status, status detail, and status reason while waiting.

Examples:
image

image

To make this work, we need access to updated zun container parameters in the wait loop. To that end, I've copied the "status" updating property approach, but just store the whole zun container dict. This allows us to fetch once per loop, and then reference parameters without re-fetching for each one.

Copy link
Contributor

@Mark-Powers Mark-Powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not sure if we want to print out every iteration, as it takes a few minutes sometimes? Maybe by default it could update only on status change?

@msherman64 msherman64 force-pushed the bugs/container_delete_error branch from 2957cff to 36c6b10 Compare February 19, 2026 17:01
@msherman64 msherman64 force-pushed the feat/expose_event_details branch from 1d93c8b to 0ebec3e Compare February 19, 2026 17:03
@msherman64 msherman64 changed the base branch from bugs/container_delete_error to master February 19, 2026 17:03
@msherman64 msherman64 force-pushed the feat/expose_event_details branch from 0ebec3e to 0320182 Compare February 19, 2026 19:55
@msherman64
Copy link
Contributor Author

Looks good. Not sure if we want to print out every iteration, as it takes a few minutes sometimes? Maybe by default it could update only on status change?

I've now ensured it only prints on status changes, and increments a counter when statuses are seen repeatedly.

@msherman64 msherman64 merged commit 36d856c into master Feb 19, 2026
3 checks passed
@msherman64 msherman64 deleted the feat/expose_event_details branch February 19, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants