Open
Conversation
Contributor
Author
|
With only the timer from submit, we get a nicer output and can default to the submit timeout. 
|
msherman64
force-pushed
the
feat/deprecate_platform_version
branch
from
d6b5877 to
c41e7cc
Compare
Mark-Powers
requested changes
Feb 18, 2026
Contributor
Mark-Powers
left a comment
Mark-Powers
left a comment
There was a problem hiding this comment.
Looks fine overall. I think we should err on the side of avoiding breaking existing notebooks.
all hosts are now on "version 2", and we can remove this logic.
with this change, create_container becomes a very simple wrapper to translate parameters into what zun expects. This removes the need for complex logic to pass the zun container to callers via error handling.
msherman64
force-pushed
the
feat/deprecate_platform_version
branch
from
c41e7cc to
ace8737
Compare
Contributor
Author
|
Now warns using warnings.warn on deprecated args. |
msherman64
force-pushed
the
feat/deprecate_platform_version
branch
from
ace8737 to
77a67ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some backwards incompatible changes, namely removing "start", "start_timeout", and "platform_version" kwargs.
As all devices are now on platform version 2, they all start automatically. (We create a k8s deployment with scale=1, which creates a pod asynchronously)
Additionally, since "create_container" is deprecated as a user facing API, we remove "wait_for_status" from it. This removes duplicate wait logic between submit and create, and removes the need for an extra exception class to pass the original container.
Review request: For each of the places kwargs are removed, should we fail explicitly, or just ignore them if set? Explicit removal for eg container.init() may break existing artifacts.