fix: handle Slack workflow/bot messages in app_mention events#2844
Merged
Conversation
Workflow-triggered app_mention events lack a "user" field (they have "bot_id" instead), causing a KeyError that silently killed message processing after the 👀 reaction was added. Branch on the event payload to determine human vs bot, then call the appropriate Slack API (users_info vs bots_info) upfront instead of relying on exception-driven control flow. Co-Authored-By: Claude Opus 4.6 <[email protected]>
sefadegirmenci
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
dosubot
Bot
added
size:M
Co-Authored-By: Claude Opus 4.6 <[email protected]>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="backend/chainlit/slack/app.py">
<violation number="1" location="backend/chainlit/slack/app.py:324">
P2: `bot_id` fallback was added in a shared path, so generic `message` events from bots/workflows are now processed as user messages without sender/subtype filtering.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
The bot_id fallback in process_slack_message was also reachable from handle_message, which handles all DM-channel messages. This caused bot/workflow messages in DMs to be processed as user messages instead of being dropped. Guard handle_message to only process human messages; workflow mentions are already handled via the app_mention event. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Split the chained .get() call to avoid a mypy type inference issue with SlackResponse's overloaded get method. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
Author
|
@hayescode @asvishnyakov This fixes the problem of accepting mentions from bots on slack. Let's say the bot is named chainlit, another bot can mention chainlit to delagate issues. Review & approve pls when you are available |
efealioksuz
approved these changes
Mar 19, 2026
Contributor
|
This fixes a real silent failure, the 👀 reaction would fire and then nothing. Branching on bot_id vs user upfront and calling the right Slack API accordingly is the correct approach. The DM handler guard is a nice defensive touch too. LGTM, approving! |
Contributor
Author
|
@willydouhard Could you take a look at this pr? It fixes an important problem we encounter within slack |
hayescode
approved these changes
Apr 1, 2026
Contributor
hayescode
left a comment
hayescode
left a comment
There was a problem hiding this comment.
Reviewed via Codex
LGTM.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
Thx @hayescode for the review. i don't think i have the merge permission |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow-triggered app_mention events lack a "user" field (they have "bot_id" instead), causing a KeyError that silently killed message processing after the 👀 reaction was added.
Branch on the event payload to determine human vs bot, then call the appropriate Slack API (users_info vs bots_info) upfront instead of relying on exception-driven control flow.
Summary by cubic
Handle Slack app_mention events from workflows and bots by using bot_id to fetch the right profile. Ignore bot/workflow messages in DMs and fix a
mypyerror in bot profile lookup to prevent crashes and misclassifying bots.Bug Fixes
user: branch tousers_infoorbots_info; fallback to_get_bot_profileonSlackApiError.mypycall-overload in_get_bot_profileby splitting chainedgetcalls.Refactors
backend/chainlit/slack/app.pywithruff.Written for commit a5db861. Summary will update on new commits.