fix: use correct logging format specifier in OAuth state validation#2841
Merged
hayescode merged 1 commit intoChainlit:mainfrom Apr 1, 2026
Merged
Conversation
Replace %1 with %s in logger.exception() call to prevent ValueError when OAuth state validation fails. Fixes Chainlit#2692
mgquach
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
dosubot
Bot
added
size:XS
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
This PR is stale because it has been open for 14 days with no activity. |
github-actions
Bot
added
the
stale
Proteusiq
approved these changes
Mar 27, 2026
Proteusiq
left a comment
Proteusiq
left a comment
There was a problem hiding this comment.
Could this be added to the next release. We are experience error logs :)
github-actions
Bot
removed
the
stale
hayescode
approved these changes
Mar 31, 2026
Contributor
hayescode
left a comment
hayescode
left a comment
There was a problem hiding this comment.
Reviewed via Codex
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix format string error in OAuth state validation logging —
%1is not a validPython logging format specifier and causes a
ValueErrorwhen the exception handler runs.Change
%1with%sinlogger.exception()call inbackend/chainlit/server.pyFixes #2692
Summary by cubic
Fix logging format specifier in OAuth state validation by replacing %1 with %s to prevent a ValueError in the exception handler.
Written for commit 650cbf9. Summary will update on new commits.