Skip to content

Add support for BENTLEY_materials_line_style - #1416

Merged
timoore merged 7 commits into
mainfrom
bentley-line-style
Jul 29, 2026
Merged

Add support for BENTLEY_materials_line_style#1416
timoore merged 7 commits into
mainfrom
bentley-line-style

Conversation

@j9liu

@j9liu j9liu commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Description

See CesiumGS/glTF#89 for the spec.

I regenerated the classes after deleting the generated folders, which seemed to flush out some unused classes (hence the random file edits included in the diff).

Issue number or link

N/A

Author checklist

  • I have submitted a Contributor License Agreement (only needed once).
  • I have done a full self-review of my code.
  • I have updated CHANGES.md with a short summary of my change (for user-facing changes).
  • I have added or updated unit tests to ensure consistent code coverage as necessary.
  • I have updated the documentation as necessary.

Testing plan

No runtime rendering implementation yet, but hopefully the unit tests suffice.

Reviewer checklist

Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.

As you review, please go through the checklist below:

  • Review and run all parts of the test plan on this branch and verify it matches expectations.
    • If the issue is a bug please make sure you can reproduce the bug in the main branch and then checkout this branch to make sure it actually solved the issue.
  • Review the code and make sure you do not have any remaining questions or concerns. You should understand the code change and the chosen approach. If you are not confident or have doubts about the code, please do not hesitate to ask questions.
  • Review the unit tests and make sure there are no missing tests or edge cases.
  • Review documentation changes and updates to CHANGES.md to make sure they accurately cover the work in this PR.
  • Verify that the Contributor License Agreement has been submitted, if needed.

@j9liu j9liu changed the title Bentley line style Add support for BENTLEY_materials_line_style Jul 14, 2026
@j9liu
j9liu marked this pull request as ready for review July 16, 2026 14:55
@j9liu j9liu added this to the August 2026 Release milestone Jul 27, 2026
@j9liu
j9liu requested a review from timoore July 27, 2026 17:48

@timoore timoore left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @j9liu ! It's kind of a shame that we have to take the glTF repo as it is without really tracking its changes in our history, but that's just the way it is. The only comment I have is about the edge visibility test.

Comment thread CesiumGltfReader/test/TestGltfReader.cpp
@timoore
timoore merged commit 1f4e85d into main Jul 29, 2026
28 checks passed
@timoore
timoore deleted the bentley-line-style branch July 29, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants