Merged
Conversation
certo-gco
approved these changes
Jan 23, 2026
certo-gco
left a comment
certo-gco
left a comment
There was a problem hiding this comment.
I really like the bidirectional generators idea.
jtoman
force-pushed
the
jtoman/async-graphcore
branch
from
38fddaa to
84fbe41
Compare
Contributor
Author
Yeah, kinda the only way for pure code to "callback" into async code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds async workflow to graphcore.
This involves refactoring the "pure" parts of the reusable nodes (tool result, initial, summarization) into separate functions, and stitching in the async/sync implementations of calling the llm. NB that the choice to use async anywhere "infects" the langgraph application, once you use async you cannot use
invokeorstreamas they throw runtime exceptions (unless you provide sync implementations of the async functions which, you know, we don't).While the metaprogramming used here is rather gnarly, it is ultimately protected by types, and isn't exposed to the end programmer.