v4#4
Merged
Merged
Conversation
Rename input 'args' to 'options' and normalize input defaults/quoting; make config default empty and install_themes boolean. Add validation steps for Cecil version and config file, add PHP setup, and improve step names. Add Pages setup and artifact upload (upload-pages-artifact) and include baseurl during build. Update workflow examples and bump referenced actions (configure-pages, upload-pages-artifact, deploy-pages) and action usage to v4.
Remove the separate `config` input and simplify how options are passed to Cecil. action.yml: drop the `config` input and its validation, always run php cecil.phar with `inputs.options` plus the Pages base URL, and rename the Pages step to "Setup GitHub Pages". README and .github/workflows/test.yml: update examples to show passing `--config` via the `options` string, adjust workflow branches to include both main and master, and simplify the example workflow to match the action changes.
Update README formatting and refactor action.yml: normalize inputs, move PHP setup earlier (remove duplicate), and add a step to resolve the output directory from inputs.options (parses --output and -o variants, defaults to _site) exporting it via GITHUB_OUTPUT. Adjust upload-pages-artifact path to use the resolved output. Minor workflow/readme whitespace cleanups.
Contributor
There was a problem hiding this comment.
Pull request overview
Modernizes the Cecil GitHub Action for v4 by unifying CLI configuration into a single options input and integrating GitHub Pages artifact upload into the composite action, with corresponding documentation and workflow updates.
Changes:
- Replace
config+argsinputs with a singleoptionsinput. - Add PHP setup, Pages configuration, dynamic output directory resolution, and Pages artifact upload inside the action.
- Update README and test workflow to reflect the new v4 interface and updated Pages deployment usage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| README.md | Updates usage and workflow examples for the new options input and v4 action usage. |
| action.yml | Implements new inputs and embeds build + Pages artifact upload logic into the composite action. |
| .github/workflows/test.yml | Updates CI workflow to use options instead of config/args. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Cecilapp/Action/sessions/eb1f0927-869f-4c24-b085-c46d34ee6056 Co-authored-by: ArnaudLigny <80580+ArnaudLigny@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Cecilapp/Action/sessions/eb1f0927-869f-4c24-b085-c46d34ee6056 Co-authored-by: ArnaudLigny <80580+ArnaudLigny@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Cecilapp/Action/sessions/eb1f0927-869f-4c24-b085-c46d34ee6056 Co-authored-by: ArnaudLigny <80580+ArnaudLigny@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the Cecil GitHub Action, modernizing its configuration, improving flexibility, and streamlining the workflow for building and deploying Cecil sites to GitHub Pages. Key improvements include a new unified
optionsinput for Cecil CLI flags, enhanced artifact upload support, and updated documentation and workflow examples to match these changes.Action input and workflow improvements:
configandargsinputs with a singleoptionsinput inaction.yml, allowing users to specify all Cecil CLI options in one place [1] [2].optionsinput, ensuring correct artifact upload regardless of custom output paths.actions/upload-pages-artifact@v5, making it easier to deploy to GitHub Pages.Documentation and example updates:
README.mdto reflect the newoptionsinput, the artifact upload step, and the latest recommended usage patterns, including updated workflow examples and GitHub Action versions [1] [2].actions/deploy-pages@v5for compatibility with the latest GitHub Pages deployment process.General enhancements and cleanup:
action.ymlfor better consistency and readability.