Skip to content

CATROID-1598 Fix test testResourceFailedDialog - #5238

Open
hannesweilharter wants to merge 3 commits into
Catrobat:developfrom
hannesweilharter:CATROID-1598
Open

CATROID-1598 Fix test testResourceFailedDialog#5238
hannesweilharter wants to merge 3 commits into
Catrobat:developfrom
hannesweilharter:CATROID-1598

Conversation

@hannesweilharter

@hannesweilharter hannesweilharter commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

The test was failing intermittently with RootViewWithoutFocusException because Espresso could select the StageActivity root, which can lose window focus during dialog creation. Since StageActivity is a LibGDX activity with its own window, its root can lack window focus during the test. Using inRoot(isDialog()) ensures Espresso searches the actual dialog window instead.

https://catrobat.atlassian.net/browse/CATROID-1598

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@sonarqubecloud

Copy link
Copy Markdown

@hannesweilharter hannesweilharter added the Active Member Tickets that are assigned to members that are still currently active label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants