#20 Changed CodeChallengeEvent to Event#39
Open
syedmalimustafa wants to merge 1 commit intoCarletonComputerScienceSociety:masterfrom
Open
#20 Changed CodeChallengeEvent to Event#39syedmalimustafa wants to merge 1 commit intoCarletonComputerScienceSociety:masterfrom
syedmalimustafa wants to merge 1 commit intoCarletonComputerScienceSociety:masterfrom
Conversation
MathyouMB
requested changes
Apr 30, 2021
Member
MathyouMB
left a comment
MathyouMB
left a comment
There was a problem hiding this comment.
Your model changes look great! 😊
One thing you will need to add though before I can merge this is a Django migration that renames the table on the database. I found this great stack overflow post that describes how you can generate such a migration: https://stackoverflow.com/questions/25091130/django-migration-strategy-for-renaming-a-model-and-relationship-fields. After you add the renaming migration we can merge! 🚢
Let me know if you have any questions.
MathyouMB
reviewed
Apr 30, 2021
|
|
||
| operations = [ | ||
| migrations.CreateModel( | ||
| name="CodeChallengeEvent", |
Member
There was a problem hiding this comment.
Please don't modify existing migrations, instead please add a new migration that renames the table. We need to do this because we already have a table and data inside this table in production.
MathyouMB
reviewed
Apr 30, 2021
| blank=True, | ||
| null=True, | ||
| on_delete=django.db.models.deletion.CASCADE, | ||
| to="codechallenges.codechallengeevent", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.