Dispersion and pebble universes#218
Open
ChasingNeutrons wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a universe which contains spherical inclusions, e.g., for TRISO-containing systems. It reads a list of sphere radii, origins, and fills, and populates the volume with them. Cell searches are accelerated by a grid (much like Serpent does, I think) which precomputes which cells are in a given grid cell. I also added in a spherical universe - equivalent to a pinUniverse in spherical co-ordinates.
As part of that work, I also refactored Cartesian grids in general. This universe was the third place in the code they were used, so I made a CartesianLattice class which those places (dispersionUni, latUni, and cartesianField) all now use. It sits in SharedModules, but perhaps it is more appropriate in geometry somewhere?
Below is an image generated using the ray tracing visualisation. With respect to performance, intriguingly this particular problem (a pebble with typical packing fraction, in a reflected boundary box) was faster with pure delta tracking than with our hybrid tracking default. This perhaps suggests I could optimize the distance calculation a bit more. Distance caching helps performance dramatically. Having it on shaved off a quarter of the runtime compared to without.
This universe was made with a script to generate particle positions. I should perhaps add this (or something like it) into cream, as well as an example input file.