Live/interactive geometry render#217
Open
ChasingNeutrons wants to merge 21 commits into
Open
Conversation
Added in the BEAVRS model with the D-bank partially inserted. Also fixed a flaw in the geometry where the outermost cell was defined such that there could be a rare particle lost between it and the geometry boundary.
Required adding normals to all surfaces and the ability to access these from cells and universes. Also modified coords to adjust direction in a given reference frame. New movement/ray tracing subroutines were added to the geometry.
It is desirable for input to allow some universes not to be offset as might be done in a lattice. ALternatively, it may be preferable to evaluate their locations in the global reference frame. The former has been done by allowing lattice universes to have an 'offset map', the latter has been done by allowing a chosen universe to be evaluated in global coordinates. This allowed a fix to the BEAVRS inputs to correctly position the instrumentation tubes. There seems to be a dictionary error with the offsetMap. Occasionally it is not recognised as an integer list. This has prevented the creation of a new test in latUniverse. This has been commented out until the dictionary has been fixed.
Added description of offsets in latUniverse and global in universe to docs. Also added an example of the offsetMap in the form of a 2D CROCUS input.
Completed live rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the ability to do live ray plots. This meant exposing some of the current ray plot to a newly created physics package. The physics package gives a command-line interface and updates an image which is read by an external program which SCONE directly calls. I've been using eog, but this can be changed in the input. I also added the ability to constrain the ray plotting domain to a specific cuboid - this makes it easier to see geometry internals without having to modify the geometry input.