changes to mirror the updates to tracking antenna#25
Conversation
Landwhich
commented
May 12, 2026
Landwhich
commented
- existing values for manual input should actually be fine be needs to be tested
- added frontend antenna tracking for fix and heading
codeflight1
left a comment
codeflight1
left a comment
There was a problem hiding this comment.
Looks good, just one note about the bearing message
|
|
||
| const handleAntennaBearing = (message: any) => { | ||
| // Assuming the /fix message contains 'latitude' and 'longitude' | ||
| const angle = message * 360; |
There was a problem hiding this comment.
What unit is this topic in? Pretty sure it is in radians. I am guessing you are trying to convert to degrees which would be *360/2pi.
There was a problem hiding this comment.
the topic actually sends out a normalized value so that the roboclaw can just do its encoder math.
There was a problem hiding this comment.
Okay that's my bad. I should have caught that in the original PR. After URC we will change that to follow ros2 rfcs which is in radians. Hardware interfaces read radians and convert to encoder ticks. It makes it harder to debug if you don't follow the standard agreed upon units.
Co-authored-by: codeflight1 <va7nfh@gmail.com>
ConnorNeed
left a comment
ConnorNeed
left a comment
There was a problem hiding this comment.
Make sure you test before you merge. Squash and merge when ready
|
Tested using the normalized values from antenna bearing and moves cw as expected |
3 participants
