Base station launch

[ConnorNeed]

Remove the nodes that will be launched on the RPi from the base station launch.

Added the exec to have systemctl stop work smoother as discussed last night

[Copilot]

Pull request overview

This PR trims the base-station bringup to remove hardware nodes intended to run on a Raspberry Pi and updates the rover startup script so the foreground Docker process replaces the shell process.

Changes:

• Removed the GPS RTCM publisher and antenna RoboClaw node from bringup’s base-station launch file.
• Kept the base-station launch focused on joystick, video streaming, and rosbridge.
• Changed setup/start_rover.sh to exec the docker run for the container launcher.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/Bringup/launch/basestation.launch.py	Removes two hardware-related ROS nodes from the base-station bringup launch.
setup/start_rover.sh	Replaces the shell with the foreground docker run process for the container launcher.

Comments suppressed due to low confidence (2)

src/Bringup/launch/basestation.launch.py:23

• This removal means ros2 launch bringup basestation.launch.py no longer starts any RTCM/base-station GPS publisher. The only remaining rtcm_pub_node launch is src/Nav/gps/launch/basestation.launch.py, and nothing in this repo includes it, so base-station correction data will disappear unless an out-of-repo RPi bringup is deployed in lockstep.

            IncludeLaunchDescription(
                PythonLaunchDescriptionSource(
                    os.path.join(
                        get_package_share_directory("joystick_control"),
                        "launch",
                        "controller.launch.py",
                    )
                )
            ),

src/Bringup/launch/basestation.launch.py:23

• After deleting the two Node actions, launch_ros.actions is now unused in this module. The bringup package runs ament_flake8, so this file will start failing lint with an unused-import error until that import is removed.

            IncludeLaunchDescription(
                PythonLaunchDescriptionSource(
                    os.path.join(
                        get_package_share_directory("joystick_control"),
                        "launch",
                        "controller.launch.py",
                    )
                )
            ),

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Landwhich]

LGTM why did it fail?

[ConnorNeed]

why did it fail?
Issue with the build machine. Fixed now