Mesh_3: Fix Documentation Glitches by afabri · Pull Request #9283 · CGAL/cgal

afabri · 2026-01-16T11:05:51Z

Summary of Changes

Template parameters must be in CamelCase
Fix template parameters in the package description

Todo

Add the Insight Tool Kit, referedto here, to the 3rd party software page
Fix some todos in the code
Remove the first two template parameters and rewrite the documentation of the third one here.
Announce the removal of deprecated feature in the CHANGES.md for 6.2

Release Management

Affected package(s): Mesh_3
Link to compiled documentation (obligatory for small feature) wrong link name to be changed
License and copyright ownership: unchanged

Mesh_3/include/CGAL/Labeled_mesh_domain_3.h

afabri · 2026-01-16T12:10:04Z

When did we deprecate this? Maybe we can remove it in this PR.

afabri · 2026-01-16T13:34:51Z

When did we deprecate this? Maybe we can remove it in this PR.

Deprecated 8 years ago in this commit

afabri · 2026-01-16T14:05:22Z

Is it correct that here we refer to the Surface_mesher package @janetournois

janetournois · 2026-01-16T14:10:27Z

Is it correct that here we refer to the Surface_mesher package @janetournois

I don't think so. What part of the page do you refer to?

afabri · 2026-01-16T14:42:59Z

Is it correct that here we refer to the Surface_mesher package @janetournois

I don't think so. What part of the page do you refer to?

I refer to the sentence "This parameter stands for a model of the concept ImplicitFunction described in the surface mesh generation package"

janetournois · 2026-01-16T15:05:25Z

Is it correct that here we refer to the Surface_mesher package @janetournois

I don't think so. What part of the page do you refer to?

I refer to the sentence "This parameter stands for a model of the concept ImplicitFunction described in the surface mesh generation package"

then yes, it is about Surface_mesher. Maybe it should be moved/copied to Mesh_3 now, since the Surface_mesher package got deprecated

github-actions · 2026-01-16T15:36:05Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9283/v0/Manual/index.html

Documentation/doc/Documentation/Third_party.txt

Co-authored-by: albert-github <[email protected]>

github-actions · 2026-01-20T10:45:40Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9283/v0/Manual/index.html

sloriot · 2026-02-03T13:14:05Z

Successfully tested in CGAL-6.2-Ic-101

Mesh_3/include/CGAL/Implicit_to_labeling_function_wrapper.h

janetournois · 2026-02-06T14:45:44Z

Mesh_3/include/CGAL/Labeled_mesh_domain_3.h


  template <typename Function,
-            typename Bounding_object,
+            typename BoundingObject,


why is this one camel-case and Construct_surface_patch_index not?

janetournois · 2026-02-06T14:50:45Z

Mesh_3/include/CGAL/Labeled_mesh_domain_3.h

   *                  and returns a scalar value. That object must be model of `CopyConstructible`
   * \tparam NamedParameters a sequence of \ref bgl_namedparameters "Named Parameters"
-   * \tparam Bounding_object either a bounding sphere (of type `Sphere_3`), a bounding box (type `Bbox_3`),
+   * \tparam BoundingObject either a bounding sphere (of type `Sphere_3`), a bounding box (type `Bbox_3`),


Suggested change

* \tparam BoundingObject either a bounding sphere (of type `Sphere_3`), a bounding box (type `Bbox_3`),

* \tparam BoundingObject either a bounding `Sphere_3`, a bounding `Bbox_3`,

Mesh_3/include/CGAL/Labeled_mesh_domain_3.h

Co-authored-by: Jane Tournois <[email protected]>

github-actions · 2026-02-06T14:55:01Z

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

afabri · 2026-02-06T16:07:49Z

/force-build:v0

github-actions · 2026-02-06T16:11:20Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9283/v0/Manual/index.html

afabri · 2026-02-06T16:24:40Z

I just noticed that Labeled_mesh_domain_3 is documented in doc and in include

afabri · 2026-02-06T16:35:25Z

/force-build:v0

github-actions · 2026-02-06T16:38:50Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9283/v0/Manual/index.html

afabri · 2026-02-06T18:25:56Z

/force-build:v0

github-actions · 2026-02-06T18:29:44Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9283/v0/Manual/index.html

Mesh_3: Fix Documentation Glitches

64aa6bd

afabri commented Jan 16, 2026

View reviewed changes

Mesh_3/include/CGAL/Labeled_mesh_domain_3.h Outdated Show resolved Hide resolved

afabri commented Jan 16, 2026

View reviewed changes

Mesh_3/include/CGAL/Labeled_mesh_domain_3.h Outdated Show resolved Hide resolved

Adress shadowing error in the CI

5cf4271

afabri requested a review from janetournois January 16, 2026 12:08

afabri added this to the 6.2-beta milestone Jan 16, 2026

afabri self-assigned this Jan 16, 2026

afabri added Pkg::Mesh_3 Doc bug Cleaning Ready to be tested labels Jan 16, 2026

afabri added 2 commits January 16, 2026 12:14

Add missing \tparam

f837bbe

Change order of \tparam

22d65d5

Remove deprecated code

713b89b

Fix NamedParameters

e35de1b

Fix CMakeLists

e0086d7

This comment was marked as outdated.

Sign in to view

afabri added 2 commits January 16, 2026 15:59

Add itk and vtk

f4d47b9

typos

00e6179

sloriot added the Under Testing label Jan 16, 2026

add missing macros

2584114

albert-github reviewed Jan 17, 2026

View reviewed changes

Documentation/doc/Documentation/Third_party.txt Outdated Show resolved Hide resolved

Update Documentation/doc/Documentation/Third_party.txt

1ec9882

Co-authored-by: albert-github <[email protected]>

This comment was marked as outdated.

Sign in to view

typo in STL_extension

7b000c2

MaelRL added the CHANGES.md not updated label Jan 20, 2026

afabri removed the CHANGES.md not updated label Jan 20, 2026

afabri added 2 commits January 20, 2026 10:33

Fix tparams of initial_points()

fe05017

undo accidental change

7604c93

This comment was marked as outdated.

Sign in to view

afabri added 4 commits January 20, 2026 10:52

Fix tparams of initial_points()

f5ce8cf

clean @cond

efa3bca

Addition to changelog

94ce7e2

Approximate depreciation date in the changelog

3a5a1f9

afabri removed the TODO label Feb 3, 2026

sloriot added Tested and removed Ready to be tested Under Testing labels Feb 3, 2026

janetournois reviewed Feb 6, 2026

View reviewed changes

Update Mesh_3/include/CGAL/Implicit_to_labeling_function_wrapper.h

a2bef76

Co-authored-by: Jane Tournois <[email protected]>

github-actions bot removed the Tested label Feb 6, 2026

afabri force-pushed the Mesh_3-glitches-GF branch from ecf54b1 to a2bef76 Compare February 6, 2026 18:09

Deal with Iso_cuboid

af55391

	* \tparam BoundingObject either a bounding sphere (of type `Sphere_3`), a bounding box (type `Bbox_3`),
	* \tparam BoundingObject either a bounding `Sphere_3`, a bounding `Bbox_3`,

Conversation

afabri commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Todo

Release Management

Uh oh!

Uh oh!

Uh oh!

afabri commented Jan 16, 2026

Uh oh!

afabri commented Jan 16, 2026

Uh oh!

afabri commented Jan 16, 2026

Uh oh!

janetournois commented Jan 16, 2026

Uh oh!

afabri commented Jan 16, 2026

Uh oh!

janetournois commented Jan 16, 2026

Uh oh!

This comment was marked as outdated.

github-actions bot commented Jan 16, 2026

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Jan 20, 2026

Uh oh!

sloriot commented Feb 3, 2026

Uh oh!

Uh oh!

janetournois Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

janetournois Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

afabri commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

afabri commented Feb 6, 2026

Uh oh!

afabri commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

afabri commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

afabri commented Jan 16, 2026 •

edited

Loading