Add a QueuedFile object - #434
Merged
Merged
Conversation
Member
Author
|
On the other hand, this idea needs some design. It's possible that the feature is too powerful and I should just special-case indexing s3 and local disk (because that's what everyone uses). Finishing #432 correctly will probably require ursadb changes. |
michalkrzem
approved these changes
Oct 30, 2024
MichalJura
reviewed
Nov 6, 2024
added 2 commits
November 18, 2024 23:10
msm-cert
force-pushed
the
feat/add-queuedfile
branch
from
November 18, 2024 22:23
6f76c74 to
de5d8eb
Compare
mickol34
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Add a QueuedFile object * Add missing fields --------- Co-authored-by: msm <msm@cert.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
A smaller version of #432.
This PR creates a "core" (database object) of the index queue that will be managed by ursadb. This will let us queue files for indexing, and index them with available plugins.
This PR doesn't add the "indexer" worker yet, since it's nontrivial and needs some careful design.