fix(redirector): improve error handling; switch to 302 redirects#784
Open
palkerecsenyi wants to merge 1 commit intoCERNDocumentServer:masterfrom
Open
fix(redirector): improve error handling; switch to 302 redirects#784palkerecsenyi wants to merge 1 commit intoCERNDocumentServer:masterfrom
palkerecsenyi wants to merge 1 commit intoCERNDocumentServer:masterfrom
Conversation
palkerecsenyi
force-pushed
the
redirector-errors
branch
from
f29e385 to
36974a9
Compare
palkerecsenyi
force-pushed
the
redirector-errors
branch
from
36974a9 to
985b4cc
Compare
* Created a new `FileNotFound` error for when a file cannot be found in any version of a record during the legacy file redirect. * Created a template to communicate this to the user a bit more cleanly. * Added tests for legacy redirects involving non-existent file names and for soft-deleted records. * Added test for restricted record files during legacy redirect * Changed legacy redirect HTTP status to 302 instead of 301 to clearly indicate to browsers that the target URL is subject to change (e.g. if a new record version is released) and should therefore not be put in a long-term cache.
palkerecsenyi
force-pushed
the
redirector-errors
branch
from
985b4cc to
248681b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileNotFounderror for when a file cannot be found in any version of a record during the legacy file redirect.