perf: specialize nth for unindexed property sources - #1037
Merged
RobertJacobsonCDC merged 1 commit intoAug 5, 2026
Merged
Conversation
Benchmark ResultsHyperfine
CriterionRegressions (slower)
Improvements (faster)
Unchanged / inconclusive (CI crosses 0%)
Not Compared (no baseline yet)
|
RobertJacobsonCDC
merged commit Aug 5, 2026
a85155f
into
RobertJacobsonCDC_705_query_profiling
21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Unindexed single-property sampling uses Algorithm L, which repeatedly calls
Iterator::nth. Relying on the default trait implementation produced a
codegen-sensitive regression in the 10,000-entity benchmark.
Specializing nth on ConcretePropertySource preserves the same behavior while
stabilizing the hot path.
Benchmark results
Revision 10k median Change from main 100k change from main
main 4.931 µs
Before fix 6.557 µs +33.0% -2.4%
After fix 4.940 µs +0.2% -1.3%
The fix recovers over 99% of the lost 10k performance while retaining the 100k
improvement.