db client fixes - #206
Conversation
|
@codex review |
🦋 Changeset detectedLatest commit: 38ee000 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Greptile SummaryThis PR hardens the Bunny Database client and migration transaction behavior.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the current constructor preserves both positional forms described in the previous threads, including calls with an omitted code and a supplied status.
|
| Filename | Overview |
|---|---|
| packages/database-client/src/client.ts | Adds transaction modes, guarded batch rollback, statement validation, timeout validation, and normalized transport errors without leaving a blocking issue. |
| packages/database-client/src/errors.ts | Extends structured error metadata while preserving both previously reported positional constructor forms. |
| packages/database-client/src/protocol.ts | Adds protocol validation and revised numeric binding behavior without an eligible blocking follow-up finding. |
| packages/cli/src/commands/db/migrations/client.ts | Requests an immediate transaction for migration batches to acquire the write lock up front. |
| packages/database-client/src/client.test.ts | Expands coverage for batch modes, rollback guards, constructor compatibility, malformed responses, and typed SQL templates. |
Reviews (4): Last reviewed commit: "fix(database-client): keep status when t..." | Re-trigger Greptile
…rs, and row decoding
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8abb3e3dd5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…row read/write counts
… keys pointing at the new table
…r constructor compat, declared cause, and keyword scan
No description provided.