Feature/public api refactor#43
Open
RusticPotatoes wants to merge 11 commits intoBot-detector:developfrom
Open
Conversation
extreme4all
requested changes
Nov 12, 2025
bases/bot_detector/api_public/core/fastapi/dependencies/session.py
Outdated
Show resolved
Hide resolved
| from bases.bot_detector.api_public import feedback, labels, player, reports | ||
|
|
||
| router = APIRouter() | ||
| v2_router = APIRouter(prefix="/v2") |
Contributor
There was a problem hiding this comment.
should be determined in the /
Contributor
Author
There was a problem hiding this comment.
need more info on what you mean? like the folder structure should determine the route?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flattened bases/api_public into feature-local packages (player, feedback, reports, labels, shared) with route files (routes.py) so each domain owns its repo + schemas; removed the old bases/bot_detector/api_public/src/** tree and introduced bases/bot_detector/api_public/routes.py for top-level /v2 wiring.
Updated server/bootstrap & tooling to the new paths (bases/bot_detector/api_public/core/server.py, docker-compose, Dockerfile, pyproject), removed the endpoints/ package, and ensured dependencies (kafka/session) import from the flattened modules.
Added FastAPI/unit tests covering routing, schemas, helper utilities, server bootstrap, and endpoint error paths (404, 422, 400, 500) under test/bases/bot_detector/api_public/ to guard the public API.