Fix/validate test network#36
Closed
panditdhamdhere wants to merge 2 commits intoBlockstreamResearch:masterfrom
Closed
Fix/validate test network#36panditdhamdhere wants to merge 2 commits intoBlockstreamResearch:masterfrom
panditdhamdhere wants to merge 2 commits intoBlockstreamResearch:masterfrom
Conversation
Fail early when `test.esplora.network` is invalid so mistyped values are caught with a clear error instead of surfacing later in runtime setup. Made-with: Cursor
Add a changelog entry for fail-fast validation of `test.esplora.network` values during test config loading. Made-with: Cursor
panditdhamdhere
changed the title
Collaborator
|
Actually, I may have already done this and forgot to remove the "TODO". Please take a look at this: https://github.com/BlockstreamResearch/smplx/blob/master/crates/cli/src/config/core.rs#L49 |
Collaborator
|
The reason the test config has a "from file" function is that we copy that test part from the "big" config into the tmp dir so that the test runner can find and read it. The config itself doesn't change during the copy, so I assume doing this check once is sufficient. |
Author
|
alright! Should we close ? |
Collaborator
|
Yep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements validation for
test.esplora.networkwhen loadingTestConfiginsmplx-test.crates/test/src/config.rswith fail-fast validation logic.Liquid,LiquidTestnet, orElementsRegtestas valid values.BadNetworkName(String)error (added incrates/test/src/error.rs) for invalid/misspelled values.CHANGELOG.mdunder0.0.2.Test Plan
cargo test -p smplx-test